Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Affiliation should not be localized on registration form #159

Closed
asmecher opened this issue Oct 16, 2020 · 3 comments
Closed

Affiliation should not be localized on registration form #159

asmecher opened this issue Oct 16, 2020 · 3 comments

Comments

@asmecher
Copy link
Member

The affiliation field on the registration form still sends (and expects) localized form data. Since OJS 3.1.2 this shouldn't be the case any more (see the relevant change for the default template.)

@ronste
Copy link
Contributor

ronste commented Jul 3, 2023

Hi @asmecher,

I just stumbled accross this issue in an OJS 3.3 installation and fixed in manually. Looking at the 3.4 code its still there.

Looks like this issue got lost somehow. ;-)

@asmecher
Copy link
Member Author

@ronste, could you open a PR with your changes? Any branch will do (main, stable-3_3_0, or stable-3_4_0) -- I can cherry-pick from there to the relevant places.

ronste added a commit to ronste/bootstrap3 that referenced this issue Jul 17, 2023
Fix localization of affiliation field (issue pkp#159)
asmecher pushed a commit that referenced this issue Aug 15, 2023
Fix localization of affiliation field (issue #159)
asmecher pushed a commit that referenced this issue Aug 15, 2023
Fix localization of affiliation field (issue #159)
@asmecher
Copy link
Member Author

Merged and cherry-picked, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants