Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDF viewer uses only half of screen height #34

Closed
HighwayStar opened this issue Sep 13, 2016 · 4 comments
Closed

PDF viewer uses only half of screen height #34

HighwayStar opened this issue Sep 13, 2016 · 4 comments
Labels

Comments

@HighwayStar
Copy link

When using Bootstrap 3 theme with current OJS master branch PDF viewer works incorrect and uses only half of screen height.

Browser console produce following warnings:

TypeError: options.container is null
http://127.0.0.1:8000/plugins/generic/pdfJsViewer/pdf.js/web/viewer.js
Line 3918


TypeError: canvas is null
http://127.0.0.1:8000/index.php/test/article/view/1/1
Line 52

bootstrap-pdfbug

bootstrap-noconsole

@NateWr NateWr added the bug label Sep 26, 2016
@NateWr
Copy link
Collaborator

NateWr commented Sep 26, 2016

Thanks for reporting @HighwayStar. This looks like something for which additional CSS code will need to be written. I've flagged it as a bug to resolve in a future update.

@NateWr
Copy link
Collaborator

NateWr commented Nov 28, 2016

NateWr@d119bc5 fixes this issue by adding some specific CSS. I did it so that it relies on the Bootstrap variables for the navbar height and links, so it should look decent in each of the bundled themes. But it might not fit every one.

@NateWr NateWr closed this as completed Nov 28, 2016
@NateWr
Copy link
Collaborator

NateWr commented Dec 7, 2016

The CSS class needs to be adjusted due to a change in the pdfJSViewer submodule.

pkp/pdfJsViewer@bac7af5

@NateWr NateWr reopened this Dec 7, 2016
@NateWr
Copy link
Collaborator

NateWr commented Feb 7, 2017

issue_view

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants