Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove nl2br requests from "submissions" page #70

Closed
jmacgreg opened this issue Dec 4, 2017 · 2 comments
Closed

Remove nl2br requests from "submissions" page #70

jmacgreg opened this issue Dec 4, 2017 · 2 comments

Comments

@jmacgreg
Copy link
Contributor

jmacgreg commented Dec 4, 2017

https://github.com/NateWr/bootstrap3/blob/6247cd201ef063b7a21d6bb8ae24e23e78ff85ea/templates/frontend/pages/submissions.tpl#L56

This is one example, I think there are one or two more on this page. I believe they have already been removed from the original core PKP-lib template files. They cause unnecessary
spaces between text components (eg. between list items or paragraphs).

@NateWr
Copy link
Collaborator

NateWr commented Dec 5, 2017

I think the checklist items should be run through nl2br, because they are not a tinymce field.

However, the copyright notice and author guidelines on that page are tinymce fields, so shouldn't be run through nl2br. This is an issue in core as well. Filed at pkp/pkp-lib#3161

@NateWr
Copy link
Collaborator

NateWr commented Dec 5, 2017

@NateWr NateWr closed this as completed Apr 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants