Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nl2br causes extra line breaks in copyright notice #3161

Closed
NateWr opened this issue Dec 5, 2017 · 2 comments
Closed

nl2br causes extra line breaks in copyright notice #3161

NateWr opened this issue Dec 5, 2017 · 2 comments
Assignees
@NateWr
Milestone
OJS/OMP 3.1.1

Comments

@NateWr
Copy link
Contributor

NateWr commented Dec 5, 2017

nl2br is called on the copyright notice, on the frontend submissions page. It shouldn't need this since it is a tinymce field.

Reported: https://github.com/NateWr/bootstrap3/issues/70
@NateWr NateWr added this to the OJS/OMP 3.1.1 milestone Dec 5, 2017
@NateWr NateWr self-assigned this Dec 5, 2017
@NateWr NateWr mentioned this issue Dec 5, 2017
Closed
NateWr added a commit to pkp/bootstrap3 that referenced this issue Dec 5, 2017
@NateWr
pkp/pkp-lib#3161 Remove nl2br from author guidelines and copyright no…
c21a0c2 
…tice
NateWr added a commit to NateWr/pkp-lib that referenced this issue Dec 5, 2017
@NateWr
pkp#3161 Remove nl2br call from copyright notice on submissions page
c10c150
@NateWr
Copy link
Contributor Author

NateWr commented Dec 5, 2017

PRs:
#3162
pkp/ojs#1749
pkp/omp#482

@bozana can you code review?

NateWr added a commit to pkp/bootstrap3 that referenced this issue Dec 5, 2017
@NateWr
Merge pull request #71 from NateWr/i3161_nl2br
ec6409f 
pkp/pkp-lib#3161 Remove nl2br from author guidelines and copyright no…
bozana added a commit that referenced this issue Dec 6, 2017
@bozana
Merge pull request #3162 from NateWr/i3161_nl2br
33b524b 
#3161 Remove nl2br call from copyright notice on submissio…
@bozana
Copy link
Collaborator

bozana commented Dec 6, 2017

Merged and closing...

@bozana bozana closed this as completed Dec 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NateWr NateWr

Labels
None yet
Projects
None yet
Milestone
OJS/OMP 3.1.1
Development

No branches or pull requests
2 participants
@bozana @NateWr