Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pass-by-reference notice #42

Merged
merged 1 commit into from Sep 14, 2018
Merged

Fix pass-by-reference notice #42

merged 1 commit into from Sep 14, 2018

Conversation

NateWr
Copy link
Member

@NateWr NateWr commented Sep 13, 2018

Clean up another PHP warning. I assume this is all straightforward but can you take a quick look @asmecher?

@asmecher
Copy link
Member

No problem with this solution, @NateWr, but in addition (for the next releases) I'd suggest getting rid of the reference requirement in PluginRegistry::register (and probably elsewhere in that class). References are almost never required, especially on objects. (Perhaps the one exception is when when passing around arrays, as we sometimes expect them to be modifiable after they're returned.)

@NateWr
Copy link
Member Author

NateWr commented Sep 14, 2018

Filed: pkp/pkp-lib#4061

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants