Skip to content

Commit

Permalink
pkp/pkp-lib#4042 record new rounds with own decision type
Browse files Browse the repository at this point in the history
  • Loading branch information
ajnyga authored and asmecher committed Mar 31, 2020
1 parent a6ed699 commit f3925a3
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 1 deletion.
5 changes: 5 additions & 0 deletions classes/workflow/EditorDecisionActionsManager.inc.php
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
// Review stage decisions actions.
define('SUBMISSION_EDITOR_DECISION_PENDING_REVISIONS', 2);
define('SUBMISSION_EDITOR_DECISION_RESUBMIT', 3);
define('SUBMISSION_EDITOR_DECISION_NEW_ROUND', 16);

// Editorial stage decision actions.
define('SUBMISSION_EDITOR_DECISION_SEND_TO_PRODUCTION', 7);
Expand Down Expand Up @@ -102,6 +103,10 @@ protected function _externalReviewStageDecisions($context, $makeDecision = true)
'name' => 'resubmit',
'title' => 'editor.submission.decision.resubmit',
),
SUBMISSION_EDITOR_DECISION_NEW_ROUND => array(
'name' => 'newround',
'title' => 'editor.submission.decision.newRound',
),
SUBMISSION_EDITOR_DECISION_ACCEPT => array(
'operation' => 'promoteInReview',
'name' => 'accept',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ function saveNewReviewRound($args, $request) {
assert(false);
}

return $this->_saveEditorDecision($args, $request, 'NewReviewRoundForm', $redirectOp, SUBMISSION_EDITOR_DECISION_RESUBMIT);
return $this->_saveEditorDecision($args, $request, 'NewReviewRoundForm', $redirectOp, SUBMISSION_EDITOR_DECISION_NEW_ROUND);
}


Expand Down Expand Up @@ -117,6 +117,8 @@ protected function _getNotificationTypeByEditorDecision($decision) {
return NOTIFICATION_TYPE_EDITOR_DECISION_PENDING_REVISIONS;
case SUBMISSION_EDITOR_DECISION_RESUBMIT:
return NOTIFICATION_TYPE_EDITOR_DECISION_RESUBMIT;
case SUBMISSION_EDITOR_DECISION_NEW_ROUND:
return NOTIFICATION_TYPE_EDITOR_DECISION_NEW_ROUND;
case SUBMISSION_EDITOR_DECISION_DECLINE:
case SUBMISSION_EDITOR_DECISION_INITIAL_DECLINE:
return NOTIFICATION_TYPE_EDITOR_DECISION_DECLINE;
Expand Down

0 comments on commit f3925a3

Please sign in to comment.