Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1090 Add Quick Start to admin guide and change config to Deployment … #1091

Merged
merged 3 commits into from
May 2, 2023

Conversation

NateWr
Copy link
Collaborator

@NateWr NateWr commented Apr 17, 2023

…section

Copy link
Member

@asmecher asmecher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, Nate! Just one suggestion.

This will create a directory for the software at `ojs-3.4.0`. Create another directory for file uploads.

```
mkdir ojs-files
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a warning that this needs to be outside the web root. (I know these are tryout instructions, but it's a very common mistake people make.)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These instructions are set up to do that automatically. The tar command creates a directory ojs-3.4.0, then the mkdir command creates a directory beside it. The last command has them launch the web server from the ojs direcettory, so it will be separate unless someone has deliberately not followed the instructions.

Do you still want me to add a warning here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes -- anyplace we mention the files directory in the context of creating or moving it, we should warn people not to put it someplace web-accessible. This remains the leading cause of security problems.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, does this look alright? 0b7fd3f

@NateWr NateWr merged commit 125d107 into pkp:main May 2, 2023
1 check passed
@NateWr
Copy link
Collaborator Author

NateWr commented May 2, 2023

Thanks @asmecher. All merged. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants