#9674 Fix update clause

pkp · Apr 25, 2024 · 54e54ca · 54e54ca
1 parent f016f71
commit 54e54ca
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 9 deletions.
diff --git a/classes/stageAssignment/StageAssignment.php b/classes/stageAssignment/StageAssignment.php
@@ -199,14 +199,13 @@ public function scopeWithRoleIds(Builder $query, ?array $roleIds): Builder
     }
 
     /**
-    * Update the model using business params.
+    * Scope a stageAssignment to only include stage assignments that are related to submissions having a specific contextId.
     */
-    public function scopeUpdateWithParams($query, array $attributes)
+    public function scopeWithContextId(Builder $query, ?int $contextId): Builder
     {
-        $convertedValues = collect($attributes)->mapWithKeys(function ($value, $key) {
-            return [Str::snake($key) => $value];
-        })->toArray();
-
-        return $query->update($convertedValues);
+        return $query->when($contextId !== null, function ($query) use ($contextId) {
+            return $query->join('submissions', 'stage_assignments.submission_id', '=', 'submissions.submission_id')
+                        ->where('submissions.context_id', $contextId);
+        });
     }
 }
diff --git a/controllers/grid/settings/roles/form/UserGroupForm.php b/controllers/grid/settings/roles/form/UserGroupForm.php
@@ -223,8 +223,13 @@ public function execute(...$functionParams)
             } else {
                 $permitMetadataEdit = $userGroup->getPermitMetadataEdit();
 
-                StageAssignment::withUserGroupId($userGroupId)
-                    ->updateWithParams(['canChangeMetadata' => $permitMetadataEdit]);
+                $stageAssignments = StageAssignment::withUserGroupId($userGroupId)
+                    ->withContextId($this->getContextId())
+                    ->get();
+
+                foreach ($stageAssignments as $stageAssignment) {
+                    $stageAssignment->update(['canChangeMetadata' => $permitMetadataEdit]);
+                }
             }
 
             $userGroup->setRecommendOnly($this->getData('recommendOnly') && in_array($userGroup->getRoleId(), $this->getRecommendOnlyRoles()));