#9674 Override the update function for stageAssignment updates

pkp · Apr 10, 2024 · 8ad99f7 · 8ad99f7
1 parent 985f70a
commit 8ad99f7
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 12 deletions.
diff --git a/classes/stageAssignment/StageAssignment.php b/classes/stageAssignment/StageAssignment.php
@@ -201,13 +201,12 @@ public function scopeWithRoleIds(Builder $query, ?array $roleIds): Builder
     /**
     * Update the model using business params.
     */
-    public function updateWithParams(array $values)
+    public function scopeUpdateWithParams($query, array $attributes)
     {
-        $convertedValues = collect($values)->mapWithKeys(function ($value, $key) {
+        $convertedValues = collect($attributes)->mapWithKeys(function ($value, $key) {
             return [Str::snake($key) => $value];
         })->toArray();
 
-        // Assuming $this is a query builder instance, not a model instance
-        return $this->update($convertedValues);
+        return $query->update($convertedValues);
     }
 }
diff --git a/controllers/grid/settings/roles/form/UserGroupForm.php b/controllers/grid/settings/roles/form/UserGroupForm.php
@@ -223,14 +223,8 @@ public function execute(...$functionParams)
             } else {
                 $permitMetadataEdit = $userGroup->getPermitMetadataEdit();
 
-                $stageAssignments = StageAssignment::withUserGroupId($userGroupId)
-                    ->get();
-
-                foreach ($stageAssignments as $stageAssignment) {
-                    $stageAssignment->updateWithParams([
-                        'canChangeMetadata' => $permitMetadataEdit,
-                    ]);
-                }
+                StageAssignment::withUserGroupId($userGroupId)
+                    ->updateWithParams(['canChangeMetadata' => $permitMetadataEdit]);
             }
 
             $userGroup->setRecommendOnly($this->getData('recommendOnly') && in_array($userGroup->getRoleId(), $this->getRecommendOnlyRoles()));