Merge pull request #8986 from bozana/6293

#6293 fix checkDuplicate in PKPPubIdPlugin
pkp · May 22, 2023 · d41b321 · d41b321
2 parents dc60449 + b9f5786
commit d41b321
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/classes/plugins/PKPPubIdPlugin.inc.php b/classes/plugins/PKPPubIdPlugin.inc.php
@@ -102,7 +102,7 @@ function manage($args, $request) {
 	/**
 	 * Get the public identifier.
 	 * @param $pubObject object
-	 * 	Submission, Representation, SubmissionFile + OJS Issue
+	 * 	Publication, Representation, SubmissionFile + OJS Issue + OMP Chapter
 	 * @return string
 	 */
 	abstract function getPubId($pubObject);
@@ -258,7 +258,7 @@ function verifyData($fieldName, $fieldValue, $pubObject, $contextId, &$errorMsg)
 			if (empty($pubIdPrefix)) return true;
 			$newPubId = $this->constructPubId($pubIdPrefix, $fieldValue, $contextId);
 
-			if (!$this->checkDuplicate($newPubId, $pubObject->getId(), get_class($pubObject), $contextId)) {
+			if (!$this->checkDuplicate($newPubId, get_class($pubObject), $pubObject->getId(), $contextId)) {
 				$errorMsg = $this->getNotUniqueErrorMsg();
 				return false;
 			}
@@ -283,7 +283,6 @@ function validatePubId($pubId) {
 	function getDAOs() {
 		return  array(
 			DAORegistry::getDAO('PublicationDAO'),
-			DAORegistry::getDAO('SubmissionDAO'),
 			Application::getRepresentationDAO(),
 			DAORegistry::getDAO('SubmissionFileDAO'),
 		);
@@ -292,7 +291,7 @@ function getDAOs() {
 	/**
 	 * Can a pub id be assigned to the object.
 	 * @param $pubObject object
-	 * 	Submission, Representation, SubmissionFile + OJS Issue
+	 * 	Publication, Representation, SubmissionFile + OJS Issue + OMP Chapter
 	 * @return boolean
 	 * 	false, if the pub id contains an unresolved pattern i.e. '%' or
 	 * 	if the custom suffix is empty i.e. the pub id null.