Merge pull request #6327 from NateWr/i6234_overdue_notice

#6234 Make overdue reviews notice clearer for authors
pkp · Nov 11, 2020 · d55739b · d55739b
2 parents af0581f + a34fa1b
commit d55739b
Show file tree

Hide file tree

Showing 4 changed files with 26 additions and 18 deletions.
diff --git a/classes/submission/reviewRound/ReviewRound.inc.php b/classes/submission/reviewRound/ReviewRound.inc.php
@@ -280,7 +280,7 @@ function getStatusKey($isAuthor = false) {
 			case REVIEW_ROUND_STATUS_REVIEWS_COMPLETED:
 				return 'editor.submission.roundStatus.reviewsCompleted';
 			case REVIEW_ROUND_STATUS_REVIEWS_OVERDUE:
-				return 'editor.submission.roundStatus.reviewOverdue';
+				return $isAuthor ? 'author.submission.roundStatus.reviewOverdue' : 'editor.submission.roundStatus.reviewOverdue';
 			case REVIEW_ROUND_STATUS_PENDING_RECOMMENDATIONS:
 				return 'editor.submission.roundStatus.pendingRecommendations';
 			case REVIEW_ROUND_STATUS_RECOMMENDATIONS_READY:

diff --git a/controllers/tab/authorDashboard/AuthorDashboardReviewRoundTabHandler.inc.php b/controllers/tab/authorDashboard/AuthorDashboardReviewRoundTabHandler.inc.php
@@ -19,6 +19,9 @@
 
 class AuthorDashboardReviewRoundTabHandler extends AuthorDashboardHandler {
 
+	/** @var boolean Overwrite backend page handling of AuthorDashboardHandler */
+	public $_isBackendPage = false;
+
 	/**
 	 * Constructor
 	 */

diff --git a/locale/en_US/submission.po b/locale/en_US/submission.po
@@ -23,6 +23,9 @@ msgstr "Provide a formatted list of references for works cited in this submissio
 msgid "author.submission.roundStatus.reviewsReady"
 msgstr "New reviews have been submitted and are being considered by the editor."
 
+msgid "author.submission.roundStatus.reviewOverdue"
+msgstr "One or more reviewers missed their deadline. The editorial team has been notified and will take action to ensure reviews are completed. You do not need to take any action at this time. You will be notified when a decision has been made."
+
 msgid "submission.confirm.message"
 msgstr "Your submission has been uploaded and is ready to be sent. You may go back to review and adjust any of the information you have entered before continuing. When you are ready, click \"Finish Submission\"."
 

diff --git a/pages/authorDashboard/PKPAuthorDashboardHandler.inc.php b/pages/authorDashboard/PKPAuthorDashboardHandler.inc.php
@@ -159,23 +159,25 @@ function setupTemplate($request) {
 			if ($fileStage && is_a($lastReviewRound, 'ReviewRound')) {
 				$editDecisionDao = DAORegistry::getDAO('EditDecisionDAO'); /* @var $editDecisionDao EditDecisionDAO */
 				$editorDecisions = $editDecisionDao->getEditorDecisions($submission->getId(), $submission->getData('stageId'), $lastReviewRound->getRound());
-				$lastDecision = array_last($editorDecisions)['decision'];
-				$revisionDecisions = [SUBMISSION_EDITOR_DECISION_PENDING_REVISIONS, SUBMISSION_EDITOR_DECISION_RESUBMIT];
-				if (!empty($editorDecisions) && in_array($lastDecision, $revisionDecisions)) {
-					$actionArgs['submissionId'] = $submission->getId();
-					$actionArgs['stageId'] = $submission->getData('stageId');
-					$actionArgs['uploaderRoles'] = ROLE_ID_AUTHOR;
-					$actionArgs['fileStage'] = $fileStage;
-					$actionArgs['reviewRoundId'] = $lastReviewRound->getId();
-					$uploadFileUrl = $request->getDispatcher()->url(
-						$request,
-						ROUTE_COMPONENT,
-						null,
-						'wizard.fileUpload.FileUploadWizardHandler',
-						'startWizard',
-						null,
-						$actionArgs
-					);
+				if (!empty($editorDecisions)) {
+					$lastDecision = array_last($editorDecisions)['decision'];
+					$revisionDecisions = [SUBMISSION_EDITOR_DECISION_PENDING_REVISIONS, SUBMISSION_EDITOR_DECISION_RESUBMIT];
+					if (in_array($lastDecision, $revisionDecisions)) {
+						$actionArgs['submissionId'] = $submission->getId();
+						$actionArgs['stageId'] = $submission->getData('stageId');
+						$actionArgs['uploaderRoles'] = ROLE_ID_AUTHOR;
+						$actionArgs['fileStage'] = $fileStage;
+						$actionArgs['reviewRoundId'] = $lastReviewRound->getId();
+						$uploadFileUrl = $request->getDispatcher()->url(
+							$request,
+							ROUTE_COMPONENT,
+							null,
+							'wizard.fileUpload.FileUploadWizardHandler',
+							'startWizard',
+							null,
+							$actionArgs
+						);
+					}
 				}
 			}
 		}