-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Localize issue and article cover images #1934
Comments
PRs: pkp-lib ojs-stable-3_0_0: #1972 |
@NateWr, could you take a look at this PR -- because you have already worked on that? This is just issue cover image localization, I will do the article cover image localization tomorrow... |
Ah, sorry @NateWr, could you please wait with this -- I forgot to consider import/export :-( |
@NateWr, the PRs above are ready for code review :-) Thanks a lot! |
Looks good @bozana! I had a couple of very minor code style questions, but feel free to merge if you disagree. I do think that we'll probably get some UX/UI feedback at some point from people who don't want to have to switch languages to upload alternate cover images. But I'm happy with this as a good-enough UX for now. |
Thanks a lot @NateWr, I'll make the suggested changes and let you know. Then I will cherry-pick it to ojs-stable-3_0_0 as well... |
@bozana I'm having some trouble with localized article images. I'm trying to update the bootstrap theme to support hte localized images: https://github.com/NateWr/bootstrap3/issues/43 However, I'm getting a Fatal Error when
I also found that I don't see the existing image in the article metadata. And if I try to upload a new image it doesn't work. The cover images work fine on an article that's never had an image uploaded before. Do I need to run a database upgrade somewhere? |
I was able to upgrade the database, though I had to manually set the core version to 3.0.0 and then upgrade to 3.0.1 ( Here's a database entry for two submissions. ID
Did I miss an upgrade routine somewhere? |
@bozana is probably not going to be available for a few days -- reopening the issue for a bit. |
@NateWr, this upgrade script change should actually consider the old and unlocalized cover images: bozana/ojs@493d18d#diff-694ad44b2764303882d41942f9516d5e and https://github.com/pkp/ojs/blob/master/dbscripts/xml/upgrade.xml#L114. Thus, I wonder why this do not change the submission 9 :-O And I wonder since when is the other entry with the array value for the coverImage for submission 10 there -- because also in the OJS 2.4.8 it is different i.e. the same as in 3.0 just that the setting name is different :-O Could you maybe also send me your DB dump? -- I could then take a look... THANKS!!! |
These issues should be considered too: PR: pkp/ojs#1128 |
@NateWr, could you code review and test the PR above? Just change the version to 3.0.0.0 before doing the DB update... THANKS! |
@bozana I ran into an error when running the upgrade.
I set the version to 3.0.0.0 in the database, then went to |
Ah, yes, I also always have to comment out this line: https://github.com/pkp/ojs/blob/master/dbscripts/xml/upgrade.xml#L110 |
Great! The upgrade worked this time and the cover image issue is fixed. 👍 |
Great, thanks @NateWr! I will then merge it... @asmecher, how about one of the following SQL statements, for solving the idempotent issue above:
? |
@bozana, yes, both those queries run OK for me. |
pkp/pkp-lib#1934 consider old cover images duplicates
PR for the plugin settings insert statement: |
Everything merged, thus closing... |
The issue cover images are not localized any more in OJS 3.0, which is a problem for journals migrating from 2.4.x, s. for example http://forum.pkp.sfu.ca/t/update-to-ojs-3-failed/21564. Thus the issue cover images should be saved localized again.
The same guilt for article cover images.
The monograph cover images are not localized. If necessary, this can be changed later, as a separate issue.
The text was updated successfully, but these errors were encountered: