Section editors can access submission and data only if they are assigned to that submission

[bozana]

At the moment section editors can access submission either if they are assigned to the section, that submission is assigned to, or if they are assigned to the submission.
In case of some file downloads, currently the section editors are only permitted to download a file if the file submission is assigned to their section, which is wrong -- a section editor does not have to be assigned to a section. S. also http://forum.pkp.sfu.ca/t/ojs-3-the-current-role-does-not-have-access-to-this-operation/24614
Thus, it would be best not to consider the section assignment at all, but only if the section editor is assigned to that submission.

Note: if a section has section editors assigned, all submissions having that section will first automatically be assigned to those section editors.

[bozana]

PRs:
pkp-lib ojs-stable-3_0_1: #2110
ojs ojs-stable-3_0_1: pkp/ojs#1148 (just submodule update for the tests)
pkp-lib master: #2116
ojs master: pkp/ojs#1154 (just submodule update for the tests)
omp master: pkp/omp#369 (just submodule update for the tests)

[bozana]

@asmecher, could you code review the PR above? I tested it with OMP as well -- it should be OK. This is for ojs-stable3_0_1, but if OK, I will cherry-pick it to master too...

[asmecher]

Thanks, @bozana -- this is a pretty profound change, but luckily not too big, and I do think it'll relieve a lot of confusion around submission access. Please go ahead.

[asmecher]

@stranack, FYI: this change means that Section Editors no longer automatically get access to submissions based on the section that it's assigned to. It only matters what submissions a section editor is assigned to. However, Section Editors get automatic assignments to new submissions in their sections.

This makes it explicit which submissions a section editor has access to, and e.g. removing a section editor's assignment to a submission will really mean they don't have access any more, even if that submission is in a section they're configured as section editor for.

Clear as mud? :)

[bozana]

everything merged, thus closing...