Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BibTeX plugin missing comma between pages and doi element #2119

Closed
ctgraham opened this issue Dec 20, 2016 · 1 comment
Closed

BibTeX plugin missing comma between pages and doi element #2119

ctgraham opened this issue Dec 20, 2016 · 1 comment
Assignees
@ctgraham
Milestone
OJS 2.4.9

Comments

@ctgraham
Copy link
Collaborator

ctgraham commented Dec 20, 2016 •
edited

OJS 2.4.8-1: BibTeX citation output is malformed.

Reported: http://forum.pkp.sfu.ca/t/probleme-mit-bibtex-modul/27053

Cause is a missing comma on:
https://github.com/pkp/ojs/blob/dbe779f2bd97e9a0f2842c4357fb56496b7179e4/plugins/citationFormats/bibtex/citation.tpl#L26
@ctgraham ctgraham self-assigned this Dec 20, 2016
ctgraham added a commit to ulsdevteam/ojs that referenced this issue Dec 20, 2016
@ctgraham
pkp/pkp-lib#2119: Add comma after pages in BibTeX citation.
f175ff8
@ctgraham ctgraham added this to the OJS 2.4.9 milestone Dec 20, 2016
@ctgraham ctgraham mentioned this issue Dec 21, 2016
Merged
asmecher added a commit to pkp/ojs that referenced this issue Dec 21, 2016
@asmecher
Merge pull request #1158 from ulsdevteam/fix-bibtex-output
115848f 
pkp/pkp-lib#2119: Add comma after pages in BibTeX citation.
asmecher pushed a commit to pkp/ojs that referenced this issue Dec 21, 2016
@ctgraham @asmecher
pkp/pkp-lib#2119: Add comma after pages in BibTeX citation.
2162bd5
@asmecher
Copy link
Member

Merged and cherry-picked to ojs-stable-2_4_8. Thanks, @ctgraham!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ctgraham ctgraham

Labels
None yet
Projects
None yet
Milestone
OJS 2.4.9
Development

No branches or pull requests
2 participants
@asmecher @ctgraham