Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OJS 2.4.x] Public Profile link from comments is broken #2348

Closed
ctgraham opened this issue Mar 9, 2017 · 1 comment
Closed

[OJS 2.4.x] Public Profile link from comments is broken #2348

ctgraham opened this issue Mar 9, 2017 · 1 comment
Assignees
@ctgraham
Milestone
OJS 2.4.9

Comments

@ctgraham
Copy link
Collaborator

ctgraham commented Mar 9, 2017

In templates/comment/comments.tpl, each call to {translate key="comments.authenticated" ... } is missing the publicProfileUrl parameter. As a result, the links to authenticated user names from .../comments/view/... all hyperlink as <a href="{$publicProfileUrl}">. See: http://forum.pkp.sfu.ca/t/how-to-get-the-public-user-profil-url/29106/10?u=ctgraham

Exists at:
https://github.com/pkp/ojs/blob/f0f718d51ce912ac99acc4bd94496147d2ae2cdf/templates/comment/comments.tpl#L33
https://github.com/pkp/ojs/blob/f0f718d51ce912ac99acc4bd94496147d2ae2cdf/templates/comment/comments.tpl#L90
https://github.com/pkp/ojs/blob/f0f718d51ce912ac99acc4bd94496147d2ae2cdf/templates/comment/comments.tpl#L132
@ctgraham ctgraham added this to the OJS 2.4.9 milestone Mar 9, 2017
@ctgraham ctgraham self-assigned this Mar 9, 2017
ctgraham added a commit to ulsdevteam/ojs that referenced this issue Mar 9, 2017
@ctgraham
pkp/pkp-lib#2348: Fix public profile links from usernames in comments.
25d47e9
@ctgraham ctgraham mentioned this issue Mar 9, 2017
Merged
asmecher added a commit to pkp/ojs that referenced this issue Mar 10, 2017
@asmecher
Merge pull request #1308 from ulsdevteam/fix-comment-public-profile-url
708e919 
pkp/pkp-lib#2348: Fix public profile links from usernames in comments.
asmecher pushed a commit to pkp/ojs that referenced this issue Mar 10, 2017
@ctgraham @asmecher
pkp/pkp-lib#2348: Fix public profile links from usernames in comments.
21d9290
@asmecher
Copy link
Member

Thanks, @ctgraham, I've merged your PR and cherry-picked across to ojs-stable-2_4_8. As you've noted, this is a pretty rarely executed backwater.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ctgraham ctgraham

Labels
None yet
Projects
None yet
Milestone
OJS 2.4.9
Development

No branches or pull requests
2 participants
@asmecher @ctgraham