Cleanup of failed upload removes all revisions of article file

[ctgraham]

@lilients, @asmecher, uploading multiple Review files in 2.4.8.x generates multiple revisions for the Review file instead of multiple review files. Is this intended functionality?

Steps to reproduce:
Login as Reviewer, navigate to review, step 4. Repeatedly upload review files.

Because ReviewerAction::uploadReviewAction() checks whether the review assignment has a single / any file, the call to ArticleFileManager::handleUpload will increment the existing file's revision number.

If the upload of a new Review file fails, when we delete the "dummy" file (without a revision id), we actually end up deleting all revisions of the Review file courtesy of $articleFileDao->deleteArticleFileById($articleFile->getFileId()).

I think this secondary problem is solved by adding the revisionId to this call. but I'm unclear if the intent is really for multiple files uploaded to a review to be different files, or different revisions of one file.

[ajnyga]

Do you mean this: #2097 (comment)

[ctgraham]

Perhaps, @ajnyga. I'm reading the other thread as a concern that supplemental files were being uploaded as new revisions of the submission file. Similarly, if I as a reviewer (or editor) in OJS2 upload multiple files to the review's "Review Step 4: Uploaded files", what do I really mean by that?

[ctgraham]

@asmecher confirms the revision increment as intended functionality here.