Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation Menus - Add site-wide primary navigation menu #3715

Closed
defstat opened this issue May 20, 2018 · 5 comments
Closed

Navigation Menus - Add site-wide primary navigation menu #3715

defstat opened this issue May 20, 2018 · 5 comments
Assignees

Comments

@defstat
Copy link
Collaborator

defstat commented May 20, 2018

Currently the primary navigation menu doesn't show at the site level (for example at the first page of an OJS site with more than one journals), even though the site-wide navigation menu tool allows the addition of a primary navigation menu.

@defstat
Copy link
Collaborator Author

defstat commented May 20, 2018

@NateWr @stranack

PRs:

pkp-lib: #3716
ojs: pkp/ojs#1976
omp: pkp/omp#540

defstat added a commit to defstat/pkp-lib that referenced this issue May 22, 2018
@defstat defstat self-assigned this May 22, 2018
@defstat
Copy link
Collaborator Author

defstat commented May 22, 2018

@NateWr I fixed the review issue and I made the PR on bootstrap 3 plugin. Just pointing out that the logic behind showing or not the search control is different between the default theme and the bootstrap theme. Specifically the default theme shows the search control if the user is within a context. The bootstrap theme shows the search control if there are any journals configured. Should we keep that difference?

bootstrap3: NateWr/bootstrap3#85

@Vitaliy-1 This issue/changes may concern your pkp/healthSciences theme development as well?

NateWr added a commit that referenced this issue May 22, 2018
[pkp-lib] #3715 Change header file to add primary nm at side-wide level
@NateWr
Copy link
Contributor

NateWr commented May 22, 2018

Thanks @defstat. Can I close this?

@NateWr
Copy link
Contributor

NateWr commented May 22, 2018

(And thanks I've filed an issue on the Bootstrap repo to look at it.)

@defstat
Copy link
Collaborator Author

defstat commented May 22, 2018

@NateWr Yes please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants