Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct missing locale key in OJS "log.review.reviewUnconsidered" #3796

Closed
asmecher opened this issue Jun 14, 2018 · 1 comment
Closed

Correct missing locale key in OJS "log.review.reviewUnconsidered" #3796

asmecher opened this issue Jun 14, 2018 · 1 comment
Assignees
@asmecher
Milestone
OJS/OMP 3.1.1-3

Comments

@asmecher
Copy link
Member

See https://forum.pkp.sfu.ca/t/locale-keys-without-any-value-in-en-us/45756. Suggest moving it to the shard library, as the language isn't application-specific.
@asmecher asmecher added this to the OJS/OMP 3.1.1-3 milestone Jun 14, 2018
@asmecher asmecher self-assigned this Jun 14, 2018
asmecher added a commit that referenced this issue Jun 14, 2018
@asmecher
#3796 Share log.review.reviewUnconsidered locale key
022a903
asmecher added a commit to pkp/omp that referenced this issue Jun 14, 2018
@asmecher
pkp/pkp-lib#3796 Share log.review.reviewUnconsidered locale key
fac04de
asmecher added a commit that referenced this issue Jun 14, 2018
@asmecher
#3796 Share log.review.reviewUnconsidered locale key
9fc990a
asmecher added a commit that referenced this issue Jun 14, 2018
@asmecher
#3796 Share log.review.reviewUnconsidered locale key
f9c7cf5
@asmecher
Copy link
Member Author

For affected OJS installations, you can apply https://github.com/pkp/pkp-lib/commit/022a90347efbe3559f0ed3fa642484fac8aff304.diff in the lib/pkp subdirectory.

ppv1979 pushed a commit to ppv1979/pkp-lib that referenced this issue Jun 15, 2018
Update ru_RU locale after pkp#3796
c674df3
mtub added a commit that referenced this issue Jul 2, 2018
@mtub
Merge pull request #3799 from ppv1979/master
5ae9e25 
Update ru_RU locale after #3796
ambs pushed a commit to ambs/pkp-lib that referenced this issue Oct 16, 2018
@asmecher @ambs
pkp#3796 Share log.review.reviewUnconsidered locale key
6faaa13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@asmecher asmecher

Labels
None yet
Projects
None yet
Milestone
OJS/OMP 3.1.1-3
Development

No branches or pull requests
1 participant
@asmecher