Can't override core templates

[NateWr]

In several places, templates call other templates with the core:<path> prefix. This prevents plugins from overriding these templates.

A quick scan suggests that we use it in several places where it is not necessary. We should remove the core: prefix from any template calls unless we're sure we never want this template overridden.

[asmecher]

@NateWr, the core: prefix is used to distinguish between application and pkp-lib repositories in cases where the same template might appear in both. Often an app-specific template will augment a built-in one using that approach.

[jamshidhashimi]

So wherever I saw core: is used, I checked if any such template exists in /templates/<path>. If it did, then I kept the core: prefix. Otherwise I removed the core: prefix.

PR:
#4416

Please review @asmecher @NateWr.

[asmecher]

@NateWr, mind if I leave this one with you? Thanks!

[NateWr]

Looks good, @jamshidhashimi! Can I get you to run the tests for OJS to ensure there's no regression here. In order to run the tests, you need to prepare a PR for OJS which adds the submodule and a special submodule commit. This will kick off the tests.

Here's a step-by-step:

1. Get the latest master version of OJS.

cd <ojs-root-dir>
git checkout master
git pull upstream master

2. Check out a new branch:

git checkout -b i3831_templates upstream/master

3. Make sure the lib/pkp submodule has your branch checked out.

cd lib/pkp
git checkout i3831-fix

3. Add the lib/pkp submodule and apply a special commit message that points to the remote/branch to test.

cd <ojs-root-dir>
git add lib/pkp
git commit -m "Submodule update ##jamshidhashimi/i3831-fix##"
git push -u origin i3831-fix

Then open a Pull Request on PKP's ojs repo with that branch, and add the link here. That will kick off the tests.

Once they pass, I can merge this. The last test in the set will always fail right now due to a bug (my fault). But once the tests finish just add a message here and I'll take a look.

If you have any difficulties with that process give me a shout.

[jamshidhashimi]

Hi @NateWr. Thank you. Following your instructions, created the submodule update to trigger tests.

PR:
pkp/ojs#2266

[NateWr]

Thanks @jamshidhashimi! Tests passed and I've merged it in. 👍