Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test suite passes despite failures in plugins tests #4076

Closed
ptrckb opened this issue Sep 19, 2018 · 1 comment
Closed

Test suite passes despite failures in plugins tests #4076

ptrckb opened this issue Sep 19, 2018 · 1 comment
Assignees
@asmecher
Projects
Tests
Milestone
3.4.0-0

Comments

@ptrckb
Copy link
Contributor

ptrckb commented Sep 19, 2018

Tests for application plugins are run but their results are ignored. For example see https://travis-ci.org/pkp/ojs/jobs/427911620#L2391
ptrckb added a commit to ptrckb/ojs that referenced this issue Sep 19, 2018
@ptrckb
pkp/pkp-lib#4076 Catch tests failures of plugins ##ptrckb/plugins-tes…
b0426f2 
…ts##
@NateWr NateWr added this to To do in Tests Sep 16, 2021
asmecher added a commit that referenced this issue Aug 5, 2022
@asmecher
#4076 Ensure that tests fail when find-based plugin tests fail
26b9228
@asmecher asmecher self-assigned this Aug 5, 2022
@asmecher asmecher added this to the 3.4 milestone Aug 5, 2022
@asmecher
Copy link
Member

asmecher commented Aug 5, 2022

With apologies for the extreme delay in getting to this -- it's fixed in the attached commit.

@asmecher asmecher closed this as completed Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@asmecher asmecher

Labels
None yet
Projects
Infrastructure
Status: Done
Tests
To do
Milestone
3.4.0-0
Development

No branches or pull requests
2 participants
@asmecher @ptrckb