Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom NMI content field should be compatible with Static Pages Field #4836

Closed
defstat opened this issue Jun 20, 2019 · 2 comments
Closed

Custom NMI content field should be compatible with Static Pages Field #4836

defstat opened this issue Jun 20, 2019 · 2 comments
Assignees
@defstat
Milestone
OJS/OMP/OPS 3.2.0...

Comments

@defstat
Copy link
Collaborator

defstat commented Jun 20, 2019

The upgrade process is trying to copy any existing Static Page to a Custom NMI with the same path and content.
The content field for Static Pages plugin is of type "longtext", while the same field for the NMIs is "text". That could result loss of data when coping a static page to a NMI.
@defstat defstat self-assigned this Jun 20, 2019
defstat added a commit to defstat/pkp-lib that referenced this issue May 3, 2020
@defstat
pkp#4836 Change type="X" to type="XL" for navigationMenuItem settings…
1518c2c 
… setting_value to adjust with StaticPages content value length
@defstat
Copy link
Collaborator Author

defstat commented May 3, 2020

@asmecher

PR
[PKP-LIB]: #5812

asmecher pushed a commit that referenced this issue May 6, 2020
@defstat
#4836 Change type="X" to type="XL" for navigationMenuItem settings se…
c4e794c 
…tting_value to adjust with StaticPages content value length (#5812)
asmecher pushed a commit that referenced this issue May 6, 2020
@defstat @asmecher
#4836 Change type="X" to type="XL" for navigationMenuItem settings se…
d1c0439 
…tting_value to adjust with StaticPages content value length (#5812)
@asmecher asmecher added this to the OJS/OMP/OPS 3.2.0-4 milestone May 6, 2020
@asmecher
Copy link
Member

asmecher commented May 6, 2020

Merged and cherry-picked back to stable-3_2_0, thanks!

@asmecher asmecher closed this as completed May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@defstat defstat

Labels
None yet
Projects
None yet
Milestone
OJS/OMP/OPS 3.2.0-4 (never released)
Development

No branches or pull requests
2 participants
@asmecher @defstat