Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make failures in provideSupplementaryFilesForReview more friendly #5689

Closed
asmecher opened this issue Mar 30, 2020 · 4 comments
Closed

Make failures in provideSupplementaryFilesForReview more friendly #5689

asmecher opened this issue Mar 30, 2020 · 4 comments
Assignees
@asmecher
Milestone
OJS/OMP/OPS 3.2.0-2

Comments

@asmecher
Copy link
Member

The OJS 2.x to 3.x upgrade process sometimes fails on provideSupplementaryFilesForReview, e.g.:

PHP Fatal error:  Uncaught Error: Call to a member function getFileId() on null in .../lib/pkp/classes/file/SubmissionFileManager.inc.php:184
Stack trace:
#0 .../classes/install/Upgrade.inc.php(1471): SubmissionFileManager->copyFileToFileStage('2561', 1, 4, NULL, true)
#1 .../lib/pkp/classes/install/Installer.inc.php(417): Upgrade->provideSupplementaryFilesForReview(Object(Upgrade), Array)
#2 .../lib/pkp/classes/install/Installer.inc.php(263): Installer->executeAction(Array)
#3 .../lib/pkp/classes/install/Installer.inc.php(186): Installer->executeInstaller()
#4 .../lib/pkp/classes/cliTool/UpgradeTool.inc.php(88): Installer->execute()
#5 .../lib/pkp/classes/cliTool/Upgra in .../lib/pkp/classes/file/SubmissionFileManager.inc.php on line 184

Make this a warning rather than a failure, and make it easier to understand.
@asmecher asmecher added this to the OJS/OMP/OPS 3.2.0-2 milestone Mar 30, 2020
@asmecher asmecher self-assigned this Mar 30, 2020
@asmecher
Copy link
Member Author

Proposed change (needs confirmation):
i5689.diff.txt

asmecher added a commit that referenced this issue Mar 31, 2020
@asmecher
#5689 Return null rather than triggering fatal error on failure
545c0db
asmecher added a commit that referenced this issue Mar 31, 2020
@asmecher
#5689 Return null rather than triggering fatal error on failure
b4fbab0
asmecher added a commit to pkp/ojs that referenced this issue Mar 31, 2020
@asmecher
pkp/pkp-lib#5689 Show warning and continue in case of missing file (r…
f7cdcdc 
…ather than fatal error)
asmecher added a commit to pkp/ojs that referenced this issue Mar 31, 2020
@asmecher
pkp/pkp-lib#5689 Show warning and continue in case of missing file (r…
31cd9ce 
…ather than fatal error)
@asmecher
Copy link
Member Author

Got confirmation that this works (XMPP chat)

@jnugent
Copy link
Member

jnugent commented Apr 5, 2020

@asmecher I've tested it as well on a large OJS2 to OJS3 upgrade (twice now), and it does indeed work very well. Thanks!

@asmecher
Copy link
Member Author

asmecher commented Apr 5, 2020

Great, thanks, @jnugent!

MedAhamada pushed a commit to Maanrifa/ojs that referenced this issue Apr 19, 2020
@asmecher @MedAhamada
pkp/pkp-lib#5689 Show warning and continue in case of missing file (r…
68f2da9 
…ather than fatal error)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@asmecher asmecher

Labels
None yet
Projects
None yet
Milestone
OJS/OMP/OPS 3.2.0-2
Development

No branches or pull requests
2 participants
@asmecher @jnugent