New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ability to disable submissions in OJS3 #5702
Comments
Related discussion here: https://forum.pkp.sfu.ca/t/how-do-i-disable-submission-option/40021 |
Hi @ajnyga , |
I think that the ability to stop accepting submission to a specific section is already there. You can just select that only editors can submit to the section. Is there a reason why this might not be enough? I guess what I have been thinking about is a journal level setting that will block all incoming submission. Enabling the setting would:
So a master switch for stopping all incoming submission and for those journals that want to receive submissions for example by email (or in a scroll delivered by a runner). They can then just edit the author instructions incordingly. |
@NateWr @asmecher we are very keen in implementing this ASAP (i.e. in the next couple of weeks): do you have any recommendation on whether it is worth implementing this in pkp-lib rather than a plugin? If pkp-lib is your suggestion, we can finalise the PR very soon, so that this can be included in the upcoming summer release |
Hi everyone, sorry I missed this when it came in. Yes, I think this would be good to have as part of the core application. A few suggestions on how I'd like to see it:
A few things to look out for during implementation:
Let me know if this sounds like it will work for your needs and if you'd like any guidance on moving forward. 👍 |
Hi @NateWr
We weren't sure what you were referring to, when you wrote about a . Was that a new pop-up notification, like the one that appears when enabling/disabling a plugin, or something more akin to a banner across the top of the page. The banner option makes more sense to us, since it needs to be on multiple pages, but I wanted to check in case there was something else on your mind. |
Yep, I'm imagining a prominent banner that says "Submissions to this journal have been disabled. Visit the workflow settings to enable submissions." |
Awesome - glad we're on the same page. Thanks! |
@NateWr in your comment on #5806 you suggested that it would make more sense to have the ability do disable submissions in the core code rather than a plugin (as we realised in #5806, we would need changes to pkp-lib in any case in order to have this feature in a plugin). Would everyone (I am thinking of @NateWr and @asmecher in particular) be happy if we open a pull request in pkp-lib / OJS to make this feature (as defined above) happen? Thanks again for your support! 👍 |
Yep! If there are any disagreements we can't resolve about what should be in core then we can figure out what hooks are needed to separate that piece out into a plugin. But let's presume that disabling submissions and archiving sections will be core settings. |
Thanks @NateWr for the quick reply! We are happy with any solution you are comfortable with 😃 Since specs have been agreed above, we are happy to start the implementation and submit a PR to be reviewed by all contributors. We might also submit the PR when it will be half-done in order to get some earlier feedback from you guys, just in case you have any preference on how things should be implemented (and we can start this conversation sooner rather than later). Thanks again, we will link the PR in this conversation once with open it 👍 |
Hi @NateWr ,
We would like to still refer to it as 'disabling submissions' if at all possible, partly because we expect journal sections to be prepared in advance as part of the use case (but kept as disabled until release), and also for submissions to be temporarily disabled with every intention of taking submissions in the future, or at the very least with every intention of the content still being live and an ongoing part of the journal. None of these use cases fit with the implications that come with 'archiving' - that the journal section has 'ended' or has been put to rest. It's a bit too 'final' sounding, is what we fear. We do however concede that the semantics here may not be terribly important in the grand scheme of things, but we hope that the best wording can be found. Perhaps there can be some compromise in that the front-end UI displays the text as 'disabling submissions' but the code refers to 'archiving'? Would love to hear your thoughts on this. Hope you're well. |
Thanks Pete, that's useful feedback. I have in mind precisely the use-case of a section that has "ended". For example, a journal that once had a "Notes from the field" section but no longer publishes into it. Aside from disabling submissions they still want people to be able to search and browse it (when we support browsing by section). I think that this is going to be the most common use case. But I can see the cases that you describe also being common enough. I guess the trick is to find language that covers the majority of use cases but is still specific enough to be descriptive for end users. Perhaps we can describe it as an "Inactive Section" and when the user is confirming an action use the phrase "Deactivate" a section. In the form, the checkbox could use language that covers both. "Deactivate this section and do not accept submissions to it". In the database the column would then be We'll need to think about how this is displayed on the frontend, if and when we implement browsing by section in core. I think there we'll find a real conflict between cases of archived sections and upcoming sections. But I guess that's for another day. |
Hi @NateWr, this works for us. We're going to implement this and then create a pull request for the feature. Thanks |
Thanks for the PRs @salmanm2003! I'm having a little bit of trouble testing them against the latest In I think you'll just need to do a fresh rebase against the latest |
(One particular hiccup you'll run into with the rebase is that we just merged some big changes to our database schema management: #2493 (comment). Where you add the database column will need to change but don't worry about this for now. I can work around that for my test and we'll get it sorted before merge.) |
Hi @NateWr, |
👍 Good work @salmanm2003! This is looking really nice. I've left comments on the pull requests with some changes -- mostly changes for language and coding conventions. In addition to the line-by-line review, here are some additional comments:
|
Hi @NateWr and (@salmanm2003 ), In response to the two mentions: Hope this helps, |
Thanks, I'm happy for it to work that way in both cases. 👍 |
Thanks @salmanm2003! The changes following code review look great with a careful attention to detail. Much appreciated! 👍 Based on our Slack discussion and the points raised previously, I think we're almost there. The following is still outstanding:
|
Hi @NateWr,
|
Thanks @salmanm2003, that looks really good! I only had a couple more very minor comments. In addition, I'm getting an error when I edit a section to deactivate it and there is only one active section. Steps to reproduce:
I noticed that this is not reproducible if more than one section is active, so it's probably just an off-by-one error. Otherwise I think we're ready to go. Reach out to me on slack and we can schedule a call to talk through the OMP/OPS steps. |
Thanks @NateWr for pointing out this issue.
|
Here is the PR for OMP: |
#5702 Ability to disable submissions in OJS3
pkp/pkp-lib#5702 Ability to disable submissions in OJS3
pkp/pkp-lib#5702 Ability to disable submissions in OMP
pkp/pkp-lib#5702 Ability to disable submissions in OPS
All PRs have been merged. 🎉 Thanks for your careful collaboration on this @PeterfordUP and for your patience shepherding this change through the full code review and test process @salmanm2003! @amandastevens this will effect documentation. From v3.3 a journal will be able to disable submissions for the whole journal, or disable submissions to a specific section (for example, to archive a section or to deactivate it). |
pkp/pkp-lib#5702 Ability to disable submissions in OJS3
Editors and Journal managers need to be able to stop new submissions being created for specific journal sections.
Often this is done when a journal stops accepting or publishing a particular kind of article, where the journal section will still need to exist with all settings in place (as it applies to published articles), but no new submissions should be allowed. Sometimes this is temporary, sometimes permanent.
There is also a use-case for new submissions to all sections to be disabled, when journals are closed-down but still hosting content, or live but not accepting new content due to temporary organisational factors, etc.
Currently, @ajnyga has mentioned that the only way to achieve part of this functionality is to edit section settings so that only editors can submit to the section. However, this does not stop submissions from all users, nor is it evident that no new submissions should be created, from this solution. Often there are large numbers of editors, and new editors over months/years, so relying on self-controlled user behaviour is a poor solution.
An ideal solution (solution A) would be:
An acceptable solution (solution B) would be:
Notes:
Solution A is preferable because:
The text was updated successfully, but these errors were encountered: