New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review and improve PluginRegistry #5878

Closed

asmecher opened this issue May 14, 2020 · 1 comment

Assignees

Milestone

OJS/OMP/OPS 3.3.0

Member

asmecher commented May 14, 2020

The PluginRegistry class has gone a long time without review/improvement. Minor issues:

Object instantiation could use a review (the instantiate function in functions.inc.php and its use)
Misplaced files lead to warnings (see e.g.: https://forum.pkp.sfu.ca/t/problems-after-upgrading-omp-3-2-0-3/60518)
Could probably benefit from the use of Exceptions rather than unhandled null returns
Self-documentation is often incomplete.

The text was updated successfully, but these errors were encountered:

asmecher added this to the OJS/OMP 3.3 (Unconfirmed) milestone

asmecher self-assigned this

asmecher added a commit to asmecher/pkp-lib that referenced this issue


          pkp#5878 Clean up PluginRegistry

2706a18

Member Author

asmecher commented May 14, 2020

asmecher added a commit that referenced this issue


          #5878 Clean up PluginRegistry

d5c9d95

asmecher closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment