Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TinyMCE can not be loaded in sr_RS@cyrillic locale #5974

Closed
NateWr opened this issue Jun 9, 2020 · 2 comments
Closed

TinyMCE can not be loaded in sr_RS@cyrillic locale #5974

NateWr opened this issue Jun 9, 2020 · 2 comments
Labels
Bug:1:Low A bug that does not have a severe consequence or affects a small number of users.
Milestone
OJS/OMP/OPS 3.2.1

Comments

@NateWr
Copy link
Member

NateWr commented Jun 9, 2020

Describe the bug
When the sr_RS@cyrillic locale is active in the UI, TinyMCE fields will not be loaded and the following error appears in the console:

Error: Syntax error, unrecognized expression: #masthead-description-control-sr_RS@cyrillic

It seems that TinyMCE will fail when asked to mount to an element with an id that includes @. When the id includes the locale, the @ character should be sanitized.

To Reproduce
Steps to reproduce the behavior:

  1. Go to Administration > Site Settings > Language and install the Cрпски language.
  2. Go to Settings > Website > Setup > Languages and enable the Cрпски language for UI.
  3. Go to Settings > Journal and enable the Cрпски language for the form.
  4. See that the Masthead field does not load TinyMCE and the error appears in the console.

What application are you using?
3.2

Additional information
Reported in the forum.
@NateWr NateWr added the Bug:1:Low A bug that does not have a severe consequence or affects a small number of users. label Jun 9, 2020
@NateWr NateWr added this to the OJS/OMP/OPS 3.2.1 milestone Jun 9, 2020
NateWr added a commit to NateWr/ui-library that referenced this issue Jun 9, 2020
@NateWr
pkp/pkp-lib#5974 Fix TinyMCE mount error when using locale with @ cha…
e3685f7 
…racter
NateWr added a commit to NateWr/ui-library that referenced this issue Jun 9, 2020
@NateWr
pkp/pkp-lib#5974 Fix TinyMCE mount error when using locale with @ cha…
2ae624f 
…racter
@NateWr
Copy link
Member Author

NateWr commented Jun 9, 2020

PRs:
pkp/ui-library#96
pkp/ui-library#97 (stable)

Tests:
pkp/ojs#2797 (stable)

NateWr added a commit to pkp/ui-library that referenced this issue Jun 9, 2020
@NateWr
Merge pull request #96 from NateWr/i5974_tinymce_cyrillic
b4ca9ec 
pkp/pkp-lib#5974 Fix TinyMCE mount error when using locale with @ cha…
NateWr added a commit to pkp/ui-library that referenced this issue Jun 9, 2020
@NateWr
Merge pull request #97 from NateWr/i5974_stable
2876095 
pkp/pkp-lib#5974 Fix TinyMCE mount error when using locale with @ cha…
@NateWr
Copy link
Member Author

NateWr commented Jun 9, 2020

Merged and backported to stable-3_2_1.

@NateWr NateWr closed this as completed Jun 9, 2020
henriqueramos pushed a commit to henriqueramos/ui-library that referenced this issue Jan 20, 2022
@NateWr
pkp/pkp-lib#5974 Fix TinyMCE mount error when using locale with @ cha…
33c6617 
…racter
henriqueramos pushed a commit to henriqueramos/ui-library that referenced this issue Jan 20, 2022
@NateWr
Merge pull request pkp#96 from NateWr/i5974_tinymce_cyrillic
31d1a6f 
pkp/pkp-lib#5974 Fix TinyMCE mount error when using locale with @ cha…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug:1:Low A bug that does not have a severe consequence or affects a small number of users.
Projects
None yet
Milestone
OJS/OMP/OPS 3.2.1
Development

No branches or pull requests
1 participant
@NateWr