Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent unwanted access to submission files #6257

Closed
NateWr opened this issue Sep 30, 2020 · 0 comments
Closed

Prevent unwanted access to submission files #6257

NateWr opened this issue Sep 30, 2020 · 0 comments
Assignees
@NateWr
Labels
Housekeeping:1:Todo Any dependency management or refactor that would be nice to have some day.

Comments

@NateWr
Copy link
Member

NateWr commented Sep 30, 2020 •
edited

The submission file policies need to be refactored to prevent access in some cases.
@NateWr NateWr added the Housekeeping:1:Todo Any dependency management or refactor that would be nice to have some day. label Sep 30, 2020
@NateWr NateWr self-assigned this Sep 30, 2020
NateWr added a commit to NateWr/pkp-lib that referenced this issue Sep 30, 2020
@NateWr
pkp#6257 Apply additional policies to submission file uploads
3f23d00
NateWr added a commit to NateWr/ojs that referenced this issue Sep 30, 2020
@NateWr
pkp/pkp-lib#6257 Move file upload policies into pkp-lib
db80d51
NateWr added a commit to NateWr/pkp-lib that referenced this issue Sep 30, 2020
@NateWr
pkp#6257 Apply additional policies to submission file uploads
95c34f1
NateWr added a commit to NateWr/pkp-lib that referenced this issue Sep 30, 2020
@NateWr
pkp#6257 Apply additional policies to submission file uploads
b2515a5
NateWr added a commit to NateWr/ojs that referenced this issue Sep 30, 2020
@NateWr
pkp/pkp-lib#6257 Apply additional policies to submission file uploads
c2b9537
NateWr added a commit to NateWr/omp that referenced this issue Sep 30, 2020
@NateWr
pkp/pkp-lib#6257 Move file upload policies into pkp-lib
0fd6395
NateWr added a commit to NateWr/pkp-lib that referenced this issue Oct 5, 2020
@NateWr
pkp#6257 Apply additional policies to submission file uploads
9b5d659
NateWr added a commit to NateWr/ops that referenced this issue Oct 5, 2020
@NateWr
pkp/pkp-lib#6257 Allow authors to upload to their own galleys
eecaf16
NateWr added a commit to NateWr/pkp-lib that referenced this issue Oct 5, 2020
@NateWr
pkp#6257 Apply additional policies to submission file uploads
dd5fe29
NateWr added a commit to NateWr/ojs that referenced this issue Oct 5, 2020
@NateWr
pkp/pkp-lib#6257 Move file upload policies into pkp-lib
38237f9
NateWr added a commit to NateWr/ojs that referenced this issue Oct 5, 2020
@NateWr
pkp/pkp-lib#6257 Apply additional policies to submission file uploads
a2d8ccf
NateWr added a commit to NateWr/ojs that referenced this issue Oct 5, 2020
@NateWr
pkp/pkp-lib#6257 Move file upload policies into pkp-lib
4e63a7c
NateWr added a commit to NateWr/pkp-lib that referenced this issue Oct 5, 2020
@NateWr
pkp#6257 Apply additional policies to submission file uploads
e42310c
NateWr added a commit to NateWr/pkp-lib that referenced this issue Oct 5, 2020
@NateWr
pkp#6257 Apply additional policies to submission file uploads
fe14c7e
NateWr added a commit to NateWr/ojs that referenced this issue Oct 5, 2020
@NateWr
pkp/pkp-lib#6257 Move file upload policies into pkp-lib
c038d9f
NateWr added a commit to NateWr/omp that referenced this issue Oct 6, 2020
@NateWr
pkp/pkp-lib#6257 Move file upload policies into pkp-lib
ba4c1c7
NateWr added a commit to NateWr/ops that referenced this issue Oct 6, 2020
@NateWr
pkp/pkp-lib#6257 Move file upload policies into pkp-lib
2f73a8c
NateWr added a commit to NateWr/pkp-lib that referenced this issue Oct 6, 2020
@NateWr
pkp#6257 Apply additional policies to submission file uploads
3656775
NateWr added a commit to NateWr/ojs that referenced this issue Oct 6, 2020
@NateWr
pkp/pkp-lib#6257 Move file upload policies into pkp-lib
6ddba0e
NateWr added a commit to NateWr/omp that referenced this issue Oct 6, 2020
@NateWr
pkp/pkp-lib#6257 Move file upload policies into pkp-lib
3edf0f7
NateWr added a commit to NateWr/pkp-lib that referenced this issue Oct 6, 2020
@NateWr
pkp#6057 Submission file policy adjustments for pkp#6257
06a6579
NateWr added a commit to NateWr/ojs that referenced this issue Oct 6, 2020
@NateWr
pkp/pkp-lib#6257 Move file upload policies into pkp-lib
eb2544e
NateWr added a commit to NateWr/pkp-lib that referenced this issue Oct 6, 2020
@NateWr
pkp#6257 Apply additional policies to submission file uploads
f7d2c24
NateWr added a commit to NateWr/pkp-lib that referenced this issue Oct 8, 2020
@NateWr
pkp#6257 Prevent subeditors from downloading files in unassigned queries
d607869
NateWr added a commit to NateWr/pkp-lib that referenced this issue Oct 8, 2020
@NateWr
pkp#6257 Prevent subeditors from downloading files in unassigned queries
68cb1b8
NateWr added a commit to NateWr/pkp-lib that referenced this issue Oct 8, 2020
@NateWr
pkp#6257 Prevent subeditors from downloading files in unassigned queries
85332c5
NateWr added a commit to NateWr/pkp-lib that referenced this issue Oct 12, 2020
@NateWr
pkp#6257 Check assocType whenever assocId is checked
9b99160
NateWr added a commit to NateWr/pkp-lib that referenced this issue Oct 12, 2020
@NateWr
pkp#6257 Check assocType whenever assocId is checked
299457d
NateWr added a commit to NateWr/pkp-lib that referenced this issue Oct 12, 2020
@NateWr
pkp#6257 Check assocType whenever assocId is checked
84c78ac
NateWr added a commit to NateWr/pkp-lib that referenced this issue Oct 19, 2020
@NateWr
pkp#6257 Remove unnecessary use of reference
dbf8d7a
NateWr added a commit to NateWr/pkp-lib that referenced this issue Oct 19, 2020
@NateWr
pkp#6257 Remove unnecessary use of reference
2eb24f7
NateWr added a commit to NateWr/pkp-lib that referenced this issue Oct 19, 2020
@NateWr
pkp#6257 Remove unnecessary use of reference
6fd7243
NateWr added a commit to NateWr/pkp-lib that referenced this issue Oct 19, 2020
@NateWr
pkp#6257 Remove unnecessary use of reference
85875ca
NateWr added a commit to NateWr/pkp-lib that referenced this issue Oct 19, 2020
@NateWr
pkp#6057 Refactor submission files
31b98d3 
- Refactor how submission files are stored
  - New PKPFileService that uses Flysystem 1.x
  - Replace FileId/Revision with revision tracking in separate table
  - Remove file system data such as mimetype from database
  - Change to filenames stored on system
- Change downloaded filenames to use name property and
  anonymise filenames for anonymous reviews.
- Add SubmissionFile schema and service class
- Add API endpoints for submission files
- Replace file upload during submission with new Vue.js component
- Move locale property from Publication to Submission
- Change language for file genre settings
- Change submission file grids to use new SubmissionFileService
- Remove ArtworkFile and SupplementaryFile classes
- Add cli tool to get constant from its value

- pkp#5134 Clear assoc assignments when file is promoted
- pkp#6257 Update submission file policies
@NateWr NateWr mentioned this issue Oct 19, 2020
Merged
NateWr added a commit to NateWr/pkp-lib that referenced this issue Oct 21, 2020
@NateWr
pkp#6257 Apply additional policies to submission file uploads
e19800e
NateWr added a commit to NateWr/ojs that referenced this issue Oct 21, 2020
@NateWr
pkp/pkp-lib#6257 Move file upload policies into pkp-lib
84ff9ec
NateWr added a commit to NateWr/pkp-lib that referenced this issue Oct 21, 2020
@NateWr
pkp#6257 Apply additional policies to submission file uploads
21da1fb
NateWr added a commit to NateWr/pkp-lib that referenced this issue Oct 21, 2020
@NateWr
pkp#6257 Apply additional policies to submission file uploads
ed70195
NateWr added a commit to NateWr/omp that referenced this issue Oct 21, 2020
@NateWr
pkp/pkp-lib#6257 Move file upload policies into pkp-lib
6e377c5
NateWr added a commit to NateWr/ops that referenced this issue Oct 21, 2020
@NateWr
pkp/pkp-lib#6257 Allow authors to upload to their own galleys
cdf96e6
NateWr added a commit that referenced this issue Oct 22, 2020
@NateWr
Merge pull request #6258 from NateWr/i6257_upload_policies
0828772 
#6257 Apply additional policies to submission file uploads
NateWr added a commit to pkp/ojs that referenced this issue Oct 22, 2020
@NateWr
Merge pull request #2875 from NateWr/i6257_upload_policies
db8a1d3 
 pkp/pkp-lib#6257 Move file upload policies into pkp-lib
NateWr added a commit to pkp/omp that referenced this issue Oct 22, 2020
@NateWr
Merge pull request #865 from NateWr/i6257_upload_policies
d45d21f 
pkp/pkp-lib#6257 Move file upload policies into pkp-lib
NateWr added a commit to pkp/ops that referenced this issue Oct 22, 2020
@NateWr
Merge pull request #65 from NateWr/i6257_upload_policies
d2c6a46 
pkp/pkp-lib#6257 Adjust file upload wizard authorization policies
NateWr added a commit that referenced this issue Oct 22, 2020
@NateWr
Merge pull request #6266 from NateWr/i6257_stable320
6aaae66 
#6257 Apply additional policies to submission file uploads
NateWr added a commit to pkp/ojs that referenced this issue Oct 22, 2020
@NateWr
Merge pull request #2877 from NateWr/i6257_stable320
5f44077 
pkp/pkp-lib#6257 Move file upload policies into pkp-lib
NateWr added a commit to pkp/omp that referenced this issue Oct 22, 2020
@NateWr
Merge pull request #866 from NateWr/i6257_stable320
4bbd12e 
[stable-3_2_0] pkp/pkp-lib#6257 Move file upload policies into pkp-lib
NateWr added a commit to pkp/ops that referenced this issue Oct 22, 2020
@NateWr
Merge pull request #66 from NateWr/i6257_stable320
6a5c89e 
[stable-3_2_0]  pkp/pkp-lib#6257 Move file upload policies into pkp-lib
NateWr added a commit that referenced this issue Oct 22, 2020
@NateWr
Merge pull request #6268 from NateWr/i6257_stable312
43fd6aa 
#6257 Apply additional policies to submission file uploads
NateWr added a commit to pkp/ojs that referenced this issue Oct 22, 2020
@NateWr
Merge pull request #2878 from NateWr/i6257_stable312
48b59e6 
[stable-3_1_2] pkp/pkp-lib#6257 Move file upload policies into pkp-lib
NateWr added a commit to pkp/omp that referenced this issue Oct 22, 2020
@NateWr
Merge pull request #867 from NateWr/i6257_stable312
4253696 
[stable-3_1_2] pkp/pkp-lib#6257 Move file upload policies into pkp-lib
NateWr added a commit to NateWr/pkp-lib that referenced this issue Oct 27, 2020
@NateWr
pkp#6057 Refactor submission files
9e8fbe2 
- Refactor how submission files are stored
  - New PKPFileService that uses Flysystem 1.x
  - Replace FileId/Revision with revision tracking in separate table
  - Remove file system data such as mimetype from database
  - Change to filenames stored on system
- Change downloaded filenames to use name property and
  anonymise filenames for anonymous reviews.
- Add SubmissionFile schema and service class
- Add API endpoints for submission files
- Replace file upload during submission with new Vue.js component
- Move locale property from Publication to Submission
- Change language for file genre settings
- Change submission file grids to use new SubmissionFileService
- Remove ArtworkFile and SupplementaryFile classes
- Add cli tool to get constant from its value

- pkp#5134 Clear assoc assignments when file is promoted
- pkp#6257 Update submission file policies
NateWr added a commit to NateWr/pkp-lib that referenced this issue Nov 12, 2020
@NateWr
pkp#6057 Refactor submission files
5f383f8 
- Refactor how submission files are stored
  - New PKPFileService that uses Flysystem 1.x
  - Replace FileId/Revision with revision tracking in separate table
  - Remove file system data such as mimetype from database
  - Change to filenames stored on system
- Change downloaded filenames to use name property and
  anonymise filenames for anonymous reviews.
- Add SubmissionFile schema and service class
- Add API endpoints for submission files
- Replace file upload during submission with new Vue.js component
- Move locale property from Publication to Submission
- Change language for file genre settings
- Change submission file grids to use new SubmissionFileService
- Remove ArtworkFile and SupplementaryFile classes
- Add cli tool to get constant from its value

- pkp#5134 Clear assoc assignments when file is promoted
- pkp#6257 Update submission file policies
@NateWr NateWr mentioned this issue Dec 4, 2020
Closed
@NateWr NateWr mentioned this issue Jan 5, 2021
Closed
@NateWr NateWr changed the title Refactor submission file policies Prevent unwanted access to submission files May 31, 2022
@NateWr NateWr closed this as completed May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NateWr NateWr

Labels
Housekeeping:1:Todo Any dependency management or refactor that would be nice to have some day.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@NateWr