New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crossref status check errors in 3.3.0-x #6887
Comments
This appears to have been separately discovered at pkp/ojs#3082. |
PRs: OJS: OPS: |
Yes, this issue seems to be the same as here: pkp/ojs#3082 @asmecher, could you take a look at the code changes? If OK, which stable branches should be fixed? @AhemNason, would it be possible for you to test the changes above?
Thus, it seems like both would work and can be used...? Thanks! |
@bozana See pkp/ojs#3087 - I'd contacted and am working with Crossref around what changed. That PR changes the domain across; a separate but related issue to pkp/ojs#3082. Their official response is (currently) that api.crossref.org/servlet/submissionDownload wasn't ever a thing 😄 -- I've explained the situation so I'm very interested in seeing what they say. |
Thanks a lot @davidjb! Yes, it would be good to just be 100% sure that we then do the right thing now. Should we then also use https://doi.crossref.org/v2/deposits instead of https://api.crossref.org/v2/deposits ? |
@bozana - just adjusting the submissionDownload URL at this point. Quoting Crossref’s staff:
So seems fine for now. This API is still operational but https://github.com/CrossRef/rest-api-doc/blob/master/deprecated/deposit_api.md indicates it may be considered deprecated. Will ask Crossref for confirmation when they reply. |
@asmecher, I will then also add that change of the domain name for the status check in the PR above (stable-3_3_0) and will then let you know... |
This API points were introduced here: #3803. |
@asmecher, the URL is changed (part of the PR above). Could you please take a look? Thanks! |
That looks OK to me, @bozana. @davidjb, does pkp/ojs#3086 check out for you? |
@asmecher Yep, looks good. This does the same as my URL-change PR in pkp/ojs#3087 and expands/fixes the error checking in a more comprehensive way than in pkp/ojs#3082 (so those both can be closed in lieu of this PR pkp/ojs#3086). The only thing I'd add is is whether the whole API response should be kept for later review if a deposit fails. At the moment, only the |
I have no objections for saving the whole XML response, but I am also not sure about the audience -- what they would like to see i.e. if XML is understandable enough -- why not... :-) |
@bozana - in my case, if any our non-tech journal managers see any error, they'd be asking for my technical input 😄 Maybe it could be the best of both worlds -- the first line could be the message and then concatenated with a few line breaks, a heading like "Technical Details:" and the full XML. It's a tiny bit repetitive but would save a non-technical user trying to grok the XML, even if it is fairly readable. |
Just noticed pkp/ojs#3091 for moving crossref out to its own repo https://github.com/pkp/crossref-ojs; I'm sure everyone's aware, just don't want these fixes to get lost in the transition. |
pkp/pkp-lib#6887 fix crossref errors handling
pkp/pkp-lib#6887 fix crossref errors handling
The PRs for stable-3_3_0 and stable 3_3_1 are merged. |
@bozana, I think this is ready for porting to |
Oh, I didn't notice that there is crossref plugin for OPS, so first now I added the changes for the OPS stable branches :-( That's why I changed the milestone to 3.3.0-6. |
pkp/pkp-lib#6887 fix crossref errors handling
pkp/pkp-lib#6887 fix crossref errors handling
pkp/pkp-lib#6887 fix crossref errors handling
pkp/pkp-lib#6887 crossref submodule update ##bozana/6887##
pkp/pkp-lib#6887 fix crossref errors handling
pkp/pkp-lib#6887 fix crossref errors handling
This is a hard one to explain but something funny is happening and I can't quite figure it out. It started with a message from Crossref asking about a journal on 3.3.0-4 who claimed they were having an issue with their deposits.
From what I can tell, all reference to
submissionDownload
in our code starts withapi.*
and notdoi.*
.Furthermore, OJS 3.3.x users trying to pull status from Crossref are seeing two errors:
An ajax error:
And this:
This error looks like this:
You might say to yourself, has something changed on Crossref's side? We do not think so, and here's why. While I cannot find any substantive changes to this
api.*
/doi.*
code from 3.2, the status query does work in 3.2 (and from 3.1.2 and up until 3.3). This is what it should do when it's accurately reporting the error. These two journals, by the way, had the same validation error in their XML deposit.And, we're seeing in the code:
So, I'm not totally sure what's happening here. Crossref said that changing the endpoint to doi.crossref.org solved all the issues for the journal at hand.
Lastly, regardless of version, all valid deposits successfully registered and properly resolve. Our issues appear to be related specifically to the status check. I'm going to send this issue to Crossref folks also just in case anyone wants to weigh in. @israelcefrin has suggested that maybe there's a change to the way the system POSTs? Because the same failed status is returning different messages.
The text was updated successfully, but these errors were encountered: