Custom email templates lost upon changing language configuration

[asmecher]

From https://forum.pkp.sfu.ca/t/records-in-email-templates-settings-are-deleted-when-enabling-forms-language-in-any-journal/68053 and https://forum.pkp.sfu.ca/t/ojs-3-2-1-1-email-templates-were-restored-to-default:

I have found the email templates in OJS 3.2.1-1 dissapear immediatly after enabling one language on Website Settings → Setup → Language in the column “Forms”, at that moment all the personalized templates in that language on email_templates_settings are deleted (from all journals in the installation).

It appears that the email templates are removed when a locale is enabled (under "Forms" but probably elsewhere). This is happening due to...

1. LanguageGridHandler::saveLanguageSetting calls PKPContextService::restoreLocaleDefaults (this call is context specific; see also another similar call a few lines later)
2. PKPContextService::restoreLocaleDefaults then calls PKPLocale::reloadLocale, which axes email templates for all contexts (!)

[asmecher]

Applying this change in lib/pkp will prevent language resets in one journal from affecting templates site-wide: 421ed84

[ajnyga]

Any chance this can be ported for 3.2 as well?

[asmecher]

@ajnyga, 421ed84 will apply directly to 3.2.x releases as well, but we're unlikely to release any more 3.2.x .tar.gz packages. Or are you working from the stable-3_2_0 git branch and need that updated?

[jmvezic]

@asmecher Can this fix safely be applied to 3.2.1-4 manually? We're going to upgrade to 3.3 soon but this is an important fix to have until then.

Edit: as far as I can tell, the only difference is

        static function reloadLocale($locale) {

instead of

        public static function reloadLocale($locale) {

[asmecher]

@jmvezic, the relevant change is a different one -- 421ed84 -- and should apply to 3.2.1-4 cleanly.

[ajnyga]

Just leaving a note here that this same bug caused a situtation where reloading a locale in one context erased Component/Genre labels from all contexts.