-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accepting a review assignment can modify the submissions' active stage #7337
Comments
The core problem seems to be here. The reason is that both Taking @asmecher's proposal, I refactored the code in order to remove the Also had to make some changes to the I have added the current PRs to the initial issue comment |
I have added PRs for If we need the same solution for stable branch, though, I can port the |
Looks great, @defstat. I've left a few comments but the fix worked well in The stable tests failed sporadically. I've restarted those, but if you see them fail again there may be a problem to sort out. Otherwise, let me know when you've addressed the comments and I'll do a final review for merge. 👍 |
[PKP-LIB][stable-3_3_0] #7337 Fix duplicate stage_id parameter of ReviewerSubmission object
[PKP-LIB][main] #7337 Remove ReviewerSubmission/ReviewerSubmissionDAO
All merged to |
Describe the bug
When a reviewer accepts a review assignment, the submission's active stage is set to the review round's stage. If a submission has been accepted and sent to the copyediting stage, it will be sent back to the review stage if a reviewer accepts the review request.
This may effect completing a review assignment too.
To Reproduce
Steps to reproduce the behavior:
What application are you using?
3.3.0-8
Additional information
See the forum report.
PRs
Branch
main
OJS: pkp/ojs#3687
OMP: pkp/omp#1292
PKP-LIB: #8517
Branch
stable-3_3_0
OJS: pkp/ojs#3690
OMP: pkp/omp#1294
PKP-LIB: #8520
The text was updated successfully, but these errors were encountered: