New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accessing user notification settings from the site throws a fatal error #8592
Comments
Confirmed on |
Looking at We now have a foreign key on the It is only possible to access the user profile at the site level for users who have roles in more than one journal. So if the user lands on this page, it is because they have roles in more than one journal. I think there are two things to do:
@asmecher just want to run this plan by you. Does this sound right to you? |
I would also be game to have the |
That was much easier, so I've done that. The |
#8592 Fix site-wide notification subscriptions form
pkp/pkp-lib#8592 Fix site-wide notification subscriptions form
pkp/pkp-lib#8592 Fix site-wide notification subscriptions form
pkp/pkp-lib#8592 Fix site-wide notification subscriptions form
Thanks all, merged to |
Describe the bug
When 2 or more journals are installed, site settings page becomes accessible to the admin user. That means that the admin user can edit own user profile from the site, without context being available. This leads to a fatal error when trying to view notification settings as they are bound to the context
To Reproduce
Steps to reproduce the behavior:
What application are you using?
OJS main branch. Stable branch also needs testing
Additional information
As it affects only users with an admin role and we don't have site-level notification settings, I'd probably just avoid loading notifications settings in this case, when context isn't available. Another option could be to display the settings for each journal, the same way as it's done for Roles.
The text was updated successfully, but these errors were encountered: