Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URN plugin for 3.4 #8940

Closed
6 tasks done
bozana opened this issue Apr 24, 2023 · 1 comment
Closed
6 tasks done

URN plugin for 3.4 #8940

bozana opened this issue Apr 24, 2023 · 1 comment
Assignees
Labels
Bug:1:Low A bug that does not have a severe consequence or affects a small number of users.

Comments

@bozana
Copy link
Collaborator

bozana commented Apr 24, 2023

Adapt URN plugin for 3.4

The issues found (s. also #6293):

  • The user can choose how URN suffixes should be: default, custom pattern and custom suffix (input field where the user enters the whole suffixes manually).
    Then there is also setting if the check number should be used. If selected, the check number should be added to the URN, no matter what suffix option the user has chosen.
    Currently, adding check number at the end of an URN is only considered for custom suffixes, when an input field is used. Then there is possibility for the user to add the check number at the end of the URN. This is implemented in that FieldUrn.js and FieldUrn.php.
    But if the user has chosen default suffixes (or a custom pattern suffixes) then the URN is calculated based on the patterns but there is no check number at the end. For these suffixes the FieldPubId is used, and the check number is not considered there.
  • ClearIssueObjectsURNs does not function
  • Not able to save the URNs
  • Publish preview in OMP does not consider all objects
  • Publication should be used instead of Submission
  • Old/unused code exists

PRs

@bozana bozana added the Bug:1:Low A bug that does not have a severe consequence or affects a small number of users. label Apr 24, 2023
@bozana
Copy link
Collaborator Author

bozana commented Apr 24, 2023

@NateWr, could you please take a look at the PR? When everything OK I will add the issue number to the commit message and PR title... Thanks a lot!
I would then in the same way solve it for the stable-3_3_0 (s. #6293)

bozana added a commit to bozana/pkp-lib that referenced this issue Apr 25, 2023
bozana added a commit to bozana/ojs that referenced this issue Apr 25, 2023
bozana added a commit to bozana/ojs that referenced this issue Apr 25, 2023
bozana added a commit to bozana/ojs that referenced this issue Apr 25, 2023
bozana added a commit to bozana/ojs that referenced this issue Apr 26, 2023
bozana added a commit to bozana/ojs that referenced this issue Apr 26, 2023
bozana added a commit to bozana/pkp-lib that referenced this issue Apr 26, 2023
bozana added a commit to bozana/omp that referenced this issue Apr 26, 2023
bozana added a commit to bozana/omp that referenced this issue Apr 26, 2023
bozana added a commit to bozana/ojs that referenced this issue Apr 26, 2023
bozana added a commit to bozana/ojs that referenced this issue Apr 26, 2023
bozana added a commit to bozana/ojs that referenced this issue Apr 26, 2023
bozana added a commit to bozana/ojs that referenced this issue Apr 26, 2023
bozana added a commit to bozana/ojs that referenced this issue Apr 26, 2023
bozana added a commit to bozana/ojs that referenced this issue Apr 26, 2023
bozana added a commit to bozana/ojs that referenced this issue Apr 26, 2023
bozana added a commit to bozana/omp that referenced this issue Apr 26, 2023
bozana added a commit to bozana/omp that referenced this issue Apr 26, 2023
bozana added a commit to bozana/omp that referenced this issue Apr 26, 2023
bozana added a commit to bozana/omp that referenced this issue Apr 26, 2023
bozana added a commit to bozana/ojs that referenced this issue Apr 27, 2023
bozana added a commit to bozana/ojs that referenced this issue Apr 27, 2023
bozana added a commit to bozana/omp that referenced this issue Apr 27, 2023
bozana added a commit to bozana/omp that referenced this issue Apr 27, 2023
bozana added a commit to bozana/ojs that referenced this issue Apr 27, 2023
bozana added a commit to bozana/ojs that referenced this issue Apr 27, 2023
bozana added a commit to bozana/omp that referenced this issue Apr 27, 2023
bozana added a commit to bozana/omp that referenced this issue Apr 27, 2023
bozana added a commit to bozana/pkp-lib that referenced this issue Apr 27, 2023
bozana added a commit to bozana/ojs that referenced this issue Apr 27, 2023
bozana added a commit to bozana/ojs that referenced this issue Apr 27, 2023
bozana added a commit to bozana/ojs that referenced this issue Apr 27, 2023
bozana added a commit to bozana/ojs that referenced this issue Apr 27, 2023
bozana added a commit to bozana/ojs that referenced this issue Apr 27, 2023
bozana added a commit to bozana/pkp-lib that referenced this issue Apr 27, 2023
bozana added a commit to bozana/ojs that referenced this issue Apr 28, 2023
bozana added a commit to bozana/ojs that referenced this issue Apr 28, 2023
bozana added a commit to bozana/ojs that referenced this issue Apr 28, 2023
bozana added a commit to bozana/omp that referenced this issue Apr 28, 2023
bozana added a commit to bozana/omp that referenced this issue Apr 28, 2023
bozana added a commit that referenced this issue Apr 28, 2023
#8940 fix clearIssueObjectsPubIds and saving URNs
bozana added a commit to pkp/ojs that referenced this issue Apr 28, 2023
bozana added a commit to pkp/omp that referenced this issue Apr 28, 2023
pkp/pkp-lib#8940 consider urnCheckNo setting, fix publish preview
@bozana bozana closed this as completed Apr 28, 2023
bozana added a commit to bozana/omp that referenced this issue May 10, 2023
bozana added a commit to bozana/ojs that referenced this issue May 10, 2023
bozana added a commit to pkp/ojs that referenced this issue May 11, 2023
bozana added a commit to pkp/omp that referenced this issue May 22, 2023
pkp/pkp-lib#8940 consider urnCheckNo setting, fix checkDuplicate, fix publish preview, clear old code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug:1:Low A bug that does not have a severe consequence or affects a small number of users.
Projects
Development

No branches or pull requests

2 participants