Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for github actions for PKP applications #9214

Closed
5 of 6 tasks
withanage opened this issue Aug 8, 2023 · 0 comments
Closed
5 of 6 tasks

Adding support for github actions for PKP applications #9214

withanage opened this issue Aug 8, 2023 · 0 comments
Assignees

Comments

@withanage
Copy link
Member

withanage commented Aug 8, 2023

Github Actions support for PKP applications

Application Validation Min Cypress Min Unittests Min Upgrade Min
OJS ✔️ 1-2 ✔️ 25-45 ✔️ 1-2 ✔️ 7-8
OPS ✔️ 1-2 ✔️ 20-25 ✔️ 1-2 ✔️ 3-2
OMP ✔️ 1-2 ✔️ 57-60 ✔️ 1-2 ✔️ 3-20

PRS

--

Remarks

  • OPS: validation failed on 3 / 10 runs
  • OMP: one integration test failed and had to be restarted (similar to Travis) 3 / 8 runs
  • GA usage: 50 containers were started randomly and placed in a queue

Disucss

  1. Shall we run upgrade tests only in pull requests and each upgrade parallaly in its own container ?
    Currently save 7-8 minutes ?

    • Pros:
      • clean code, can easily add windows machines etc. at a later time
    • Cons:
      • uses only one container and installs the pkp application only once
      • have to maintain the variables in yml seperately
  2. Validation errors current problem

    • Reason: Linter seems to use a library which only support python 2.7 and no more maintained.
      Easier solution: fork the repository and create python 3.x support (travis 3.8 , GA 3.11 currently)
      Otherwise: look for alternative tools
  3. Are the steps explainable enough ?


Next steps

  1. create the datasets and write back to the dataset repository

Early testing


Ideas

  • Rename Cypress data tests to user names to reflect actions they perform
  • Create a configuration to run certain integration tests during development
  • Should we run for different database versions to give better recommendations, especially for prs
  • Run all application tests in a pkp-lib pull request (we can get rid of commit naming for submodule updates)
  • Get rid of all shell scripts
  • Regression for each step (calculate mean time per step)
@withanage withanage self-assigned this Aug 8, 2023
withanage added a commit to withanage/pkp-lib that referenced this issue Aug 8, 2023
withanage added a commit to withanage/ojs that referenced this issue Aug 9, 2023
withanage added a commit to withanage/ojs that referenced this issue Aug 9, 2023
withanage added a commit to withanage/ojs that referenced this issue Aug 9, 2023
withanage added a commit to withanage/ojs that referenced this issue Aug 9, 2023
withanage added a commit to withanage/ojs that referenced this issue Aug 9, 2023
withanage added a commit to withanage/ojs that referenced this issue Aug 9, 2023
withanage added a commit to withanage/ojs that referenced this issue Aug 9, 2023
withanage added a commit to withanage/ojs that referenced this issue Aug 9, 2023
withanage added a commit to withanage/ojs that referenced this issue Aug 9, 2023
withanage added a commit to withanage/ojs that referenced this issue Aug 9, 2023
withanage added a commit to withanage/ojs that referenced this issue Aug 9, 2023
withanage added a commit to withanage/ojs that referenced this issue Aug 9, 2023
withanage added a commit to withanage/ojs that referenced this issue Aug 9, 2023
withanage added a commit to withanage/ojs that referenced this issue Aug 9, 2023
withanage added a commit to withanage/ojs that referenced this issue Aug 9, 2023
withanage added a commit to withanage/ojs that referenced this issue Aug 9, 2023
withanage added a commit to withanage/ojs that referenced this issue Aug 9, 2023
withanage added a commit to withanage/ojs that referenced this issue Aug 9, 2023
withanage added a commit to withanage/ojs that referenced this issue Aug 9, 2023
withanage added a commit to withanage/ojs that referenced this issue Aug 9, 2023
withanage added a commit to withanage/ojs that referenced this issue Aug 9, 2023
withanage added a commit to withanage/ojs that referenced this issue Aug 9, 2023
withanage added a commit to withanage/ojs that referenced this issue Oct 28, 2023
withanage added a commit to withanage/pkp-lib that referenced this issue Oct 28, 2023
withanage added a commit to withanage/pkp-lib that referenced this issue Oct 28, 2023
withanage added a commit to withanage/pkp-lib that referenced this issue Oct 28, 2023
withanage added a commit to withanage/pkp-lib that referenced this issue Oct 28, 2023
withanage added a commit to withanage/ojs that referenced this issue Apr 22, 2024
withanage added a commit to withanage/ojs that referenced this issue Apr 22, 2024
asmecher pushed a commit to pkp/ojs that referenced this issue Apr 22, 2024
withanage added a commit to withanage/ojs that referenced this issue Apr 23, 2024
withanage added a commit to withanage/omp that referenced this issue Apr 23, 2024
withanage added a commit to withanage/omp that referenced this issue Apr 23, 2024
withanage added a commit to withanage/omp that referenced this issue Apr 23, 2024
withanage added a commit to withanage/omp that referenced this issue Apr 23, 2024
withanage added a commit to withanage/ops that referenced this issue Apr 23, 2024
withanage added a commit that referenced this issue Apr 24, 2024
withanage added a commit to withanage/omp that referenced this issue Apr 24, 2024
withanage added a commit to withanage/ops that referenced this issue Apr 24, 2024
withanage added a commit to withanage/ojs that referenced this issue Apr 24, 2024
xmlFlow pushed a commit to xmlFlow/ojs that referenced this issue Apr 24, 2024
xmlFlow pushed a commit to xmlFlow/ojs that referenced this issue Apr 24, 2024
xmlFlow pushed a commit to xmlFlow/ojs that referenced this issue Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant