Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the min/max length for login Username/Email #9731

Closed
touhidurabir opened this issue Feb 15, 2024 · 2 comments
Closed

Remove the min/max length for login Username/Email #9731

touhidurabir opened this issue Feb 15, 2024 · 2 comments
Assignees
@touhidurabir
Milestone
3.4.0-5

Comments

@touhidurabir
Copy link
Member

touhidurabir commented Feb 15, 2024 •
edited

Describe the bug
With the merge of #8871, we now have login via Email starting from 3.4.0-4 . But there is max length attribute with value 32 set for username/email field that restrict providing a longer email address . This cause issue for users who has long email address and want to use email address to login into the system .

To Reproduce
Steps to reproduce the behaviour:

  1. Go to login page
  2. Try to put a email address more that 32 chars
  3. see that after typing 32 chars, one can not type rest of it .

What application are you using?
OJS, OMP or OPS version 3.4.0-4 and main

Additional information
These has been reported in the forum at https://forum.pkp.sfu.ca/t/ojs-username-email-field-on-login-page-is-too-short-32-chars-for-long-email-addresses/86336

PRs

stable-3.4.0

pkp-lib --> #9732
ojs --> pkp/ojs#4188 [TEST ONLY]
@touhidurabir touhidurabir changed the title Removed the min/max length for login Username/Email and Password Remove the min/max length for login Username/Email and Password Feb 15, 2024
@touhidurabir touhidurabir changed the title Remove the min/max length for login Username/Email and Password Remove the min/max length for login Username/Email Feb 15, 2024
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Feb 15, 2024
@touhidurabir
pkp#9731 removed max length restriction for auth key in login
4e624cf
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Feb 15, 2024
@touhidurabir
pkp/pkp-lib#9731 Submodule Update ##touhidurabir/i9731_stable_3_4_0##
aaad5f1
This was referenced Feb 15, 2024
Merged
Open
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Feb 15, 2024
@touhidurabir
pkp#9731 removed max length restriction for auth key in login
a6b219a
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Feb 15, 2024
@touhidurabir
pkp/pkp-lib#9731 Submodule Update ##touhidurabir/i9731_stable_3_4_0##
3de3aca
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Feb 15, 2024
@touhidurabir
pkp/pkp-lib#9731 Submodule Update ##touhidurabir/i9731_stable_3_4_0##
faec68c
@touhidurabir touhidurabir self-assigned this Feb 16, 2024
@touhidurabir
Copy link
Member Author

@asmecher take a look , very simple PR and if all ok, I will forward port to main .

asmecher pushed a commit that referenced this issue Feb 16, 2024
@touhidurabir
#9731 removed max length restriction for auth key in login (#9732)
ae1fb80
asmecher pushed a commit that referenced this issue Feb 16, 2024
@touhidurabir @asmecher
#9731 removed max length restriction for auth key in login (#9732)
1cbc88e
@asmecher
Copy link
Member

Merged and cherry-picked forward to main, thanks!

@asmecher asmecher added this to the 3.4.0-5 milestone Feb 16, 2024
ipula pushed a commit to ipula/pkp-lib that referenced this issue Feb 22, 2024
@touhidurabir @ipula
pkp#9731 removed max length restriction for auth key in login (pkp#9732)
a2c2d93
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@touhidurabir touhidurabir

Labels
None yet
Projects
None yet
Milestone
3.4.0-5
Development

No branches or pull requests
2 participants
@asmecher @touhidurabir