Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkp/pkp-lib#6710 Unserialize journal settings depending on a value data type #6715

Merged
merged 1 commit into from Feb 5, 2021
Merged

pkp/pkp-lib#6710 Unserialize journal settings depending on a value data type #6715

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
27 changes: 19 additions & 8 deletions classes/migration/upgrade/PKPv3_3_0UpgradeMigration.inc.php
View file
Open in desktop
Expand Up @@ -176,19 +176,30 @@ public function up() {
'clockssLicense',
'lockssLicense',
];
$rows = Capsule::table('journal_settings as js')
->join('journals as j', 'j.journal_id', '=', 'js.journal_id')
$contextDao = Application::getContextDAO();
$tableName = $contextDao->tableName;
$settingsTableName = $contextDao->settingsTableName;
$primaryKeyColumn = $contextDao->primaryKeyColumn;
$rows = Capsule::table($settingsTableName . ' as js')
->join($tableName . ' as j', 'j.' . $primaryKeyColumn, '=', 'js.' . $primaryKeyColumn)
->where('js.setting_name', '=', 'supportedFormLocales')
->select(['js.journal_id as id', 'js.setting_value as locales'])
->select(['js.' . $primaryKeyColumn . ' as id', 'js.setting_value as locales'])
->get();
foreach ($rows as $row) {
// account for some locale settings stored as assoc arrays
$locales = empty($row->locales) ? [] : json_decode($row->locales, true);
$locales = $row->locales;
if (empty($locales)) {
$locales = [];
} elseif (@unserialize($locales) !== false ) {
$locales = unserialize($locales);
} else {
$locales = json_decode($locales, true);
}
$locales = array_values($locales);
Capsule::table('journal_settings as js')
->where('js.journal_id', '=', $row->id)
->whereIn('js.setting_name', $settingsWithDefaults)
->whereNotIn('js.locale', $locales)
Capsule::table($settingsTableName)
->where($primaryKeyColumn, '=', $row->id)
->whereIn('setting_name', $settingsWithDefaults)
->whereNotIn('locale', $locales)
->delete();
}
}
Expand Down