pkp/pkp-lib#8850 Add disabled property for form text in ui-library #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asmecher
requested changes
Mar 21, 2023
| @@ -90,6 +88,7 @@ export default { | |||
| props: { | |||
| inputType: String, | |||
| optIntoEdit: Boolean, | |||
| disableFeild: Boolean, | |||
There was a problem hiding this comment.
Should be disableField (here and elsewhere)
There was a problem hiding this comment.
I wll fix this and recommit
| @@ -80,7 +78,7 @@ | |||
| </div> | |||
| </div> | |||
| </template> | |||
|
|
|||
| optIntoEdit | |||
There was a problem hiding this comment.
This looks like left-over debugging text.
There was a problem hiding this comment.
I will check I think merging issue
| @@ -52,8 +52,6 @@ | |||
| /> | |||
| <span | |||
| v-if="prefix" | |||
| class="pkpFormField__inputPrefix" | |||
There was a problem hiding this comment.
Are these two lines removed for a reason?
There was a problem hiding this comment.
I think this also merging issue
ipula
force-pushed
the
issue-29
branch
2 times, most recently
from
3e4f6ac
to
abdc9fb
Compare
withanage
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding disabling function for form text field
