pkp/pkp-lib#9453 Let reviewers view their recommendations for previous rounds #313
Conversation
|
|
||
| function formatShortDate(dateString) { | ||
| return moment(dateString).format('DD-MM-YYYY'); | ||
| } | ||
|
|
There was a problem hiding this comment.
This should be localised - but thats something to investigate for me separately - pkp/pkp-lib#9733 .
| </template> | ||
| <p v-html="store.reviewRoundHistory.declineEmail.subject" class="mb-4 font-bold"></p> | ||
| <hr class="opacity-50"> | ||
| <p v-html="store.reviewRoundHistory.declineEmail.body" class="mt-4"></p> |
There was a problem hiding this comment.
I don't think that separation line between subject and body is needed, bold font might be good enough. But we can leave that to Devika's feedback, once both scenario (accepted and declined) are available in storybook she can provide feedback how to better format some of these things.
|
Hi @jardakotesovec , I made the required changes on the UI, but I still need to improve the data used for the storybook. I might do it next monday. |
|
@jardakotesovec I think I'm done with the review history mocks. You can take a look and hopefully it's good enough to be accepted :) |
|
@nibou230 Thanks a lot, looking good to me. I asked @Devika008 to review in chromatic in case she has some ui feedback, will remind her. |
No description provided.