Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkp/pkp-lib#5885 updated and added new UI component #333

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

pkp/pkp-lib#5885 updated and added new UI component #333

wants to merge 5 commits into from

Conversation

touhidurabir
Copy link
Member

@touhidurabir touhidurabir mentioned this pull request Feb 28, 2024
Open
@touhidurabir
Copy link
Member Author

Hi @jardakotesovec , can you take a look at the PR now . I have removed any extra component and have the disable/enable now as part of slider component . But just could not make few tailwind css class work so design still a bit mess .

@touhidurabir touhidurabir force-pushed the i5885_main branch 2 times, most recently from bb564a2 to 7dabf2c Compare June 13, 2024 18:03
@jardakotesovec
Copy link
Collaborator

@touhidurabir Hi Touhidur - I see there are some changes - can you remind me is this still something to be reviewed? If so - can you just describe briefly what scenario is this addressing? Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asmecher asmecher asmecher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@touhidurabir @jardakotesovec @asmecher