Added Windows support #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
very cool! |
|
npm published as 0.0.4 |
|
Actually 0.0.5. As I was unable to get it to be published as 0.0.4. |
|
Awesome, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added Windows support to
tree-kill. This is achieved by using the Windows-specific command taskkill with the flags to kill bypid(/pid), its tree (/T), and force the kill (/F).If you want to granularize the signals to use
/Fonly when it is aSIGKILLor something similar, please let me know.Background: I am working on a
node_modulecalled listen-spawn but was having trouble for Windows support due to not being able to tear down children of children in Windows viaprocess.kill(). As I eventually discovered, this was being caused by Windows functionality which immediately kills the process disallowing child cleanup. I eventually found that nodemon uses this technique to kill its children and decided to use it.