Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/improve init #141

Merged
merged 1 commit into from
Dec 25, 2023
Merged

Feat/improve init #141

merged 1 commit into from
Dec 25, 2023

Conversation

RobWalt
Copy link
Contributor

@RobWalt RobWalt commented Dec 22, 2023

There are some subtle ways to improve the init command.

  1. We still rely on manually working on strings to do the member auto detection.
  • There are better ways to do this in the mean time, namely the cargo-util-schemas crate (which we probably want to use in other places as well)
  • I replaced the code working on string with it and ensured to use the to_pretty_string serialization method, which will do the same formatting as we tried to achieve manually
  1. The workspace init command doesn't set the workspace resolver and doesn't even expose an API to do that as an opt-in
  • I added an optional command line argument resolver to pick the resolver version (1 or 2)
  • If no resolver was chosen, it defaults to v2 as it is the newer one
  • The user is informed about the actions taken in both scenarios above (explicit choice or auto choice)

@RobWalt
Copy link
Contributor Author

RobWalt commented Dec 22, 2023

CI is only failing because of the new info logs which make the insta tests fail. I just thought it would be a nice addition to tell the user more about what's going on

@pksunkara pksunkara merged commit 3d925ea into pksunkara:master Dec 25, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants