Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package i to use browser side (with RequireJS) #5

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Package i to use browser side (with RequireJS) #5

wants to merge 12 commits into from

Conversation

Y--
Copy link

@Y-- Y-- commented Mar 7, 2014

  • code cleaning using JSHint ;
  • initial seed for browser-side testing (ideally it would be great to migrate tests from vows to mocha to use them server and browser side) ;
  • upgraded Vows to 0.0.7 to be compatible with Node.JS > 0.8
  • make sure that test are still valid ;
  • ensure compatibility with Node's require mechanism.

@pksunkara
Copy link
Owner

@Y-- Thank you for the patch.

Unfortunately I am travelling around until next week. I will review and merge this when I have some free time.

Thanks

@Y--
Copy link
Author

Y-- commented Mar 7, 2014

Sure no problem! Thanks for your great lib !

Best

@Y--
Copy link
Author

Y-- commented Apr 24, 2014

Hi @pksunkara did you had a chance to take a look at this PR? Thanks !

@shadowplay1
Copy link

9 years later...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants