New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Package i to use browser side (with RequireJS) #5
Open
Y--
wants to merge
12
commits into
pksunkara:master
Choose a base branch
from
sutoiku:master
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+685
−519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Y--
commented
Mar 7, 2014
- code cleaning using JSHint ;
- initial seed for browser-side testing (ideally it would be great to migrate tests from vows to mocha to use them server and browser side) ;
- upgraded Vows to 0.0.7 to be compatible with Node.JS > 0.8
- make sure that test are still valid ;
- ensure compatibility with Node's require mechanism.
@Y-- Thank you for the patch. Unfortunately I am travelling around until next week. I will review and merge this when I have some free time. Thanks |
Sure no problem! Thanks for your great lib ! Best |
Hi @pksunkara did you had a chance to take a look at this PR? Thanks ! |
9 years later... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.