Add pagination support to the repo.branches calls. #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -104,8 +104,8 @@ class Repo | |||
|
|
|||
| # Get the branches for a repository | |||
| # '/repos/pksunkara/hub/branches' GET | |||
There was a problem hiding this comment.
Could you please add the pagination comments here?
# - page or query object, optional - params[0]
# - per_page, optional - params[1]
|
Other than the comment, lgtm. |
…iting the built version of the patch command from pksunkara#129
joshrp
force-pushed
the
branches-pagination
branch
from
676009d
to
66584b6
Compare
|
Sorted @pksunkara, thanks |
|
DAMN YOU CLOSE BUTTON! |
pksunkara
added a commit
that referenced
this pull request
Aug 29, 2014
Add pagination support to the repo.branches calls.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also includes commiting the built version of the patch command from #129