Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Nova 4.x Support #48

Merged
merged 2 commits into from
Apr 17, 2022
Merged

Adds Nova 4.x Support #48

merged 2 commits into from
Apr 17, 2022

Conversation

dmason30
Copy link
Contributor

@dmason30 dmason30 commented Apr 14, 2022

This adds Nova 4.0 only support and has breaking changes and would, therefore, be a major release.

  • Upgraded to Nova 4.0 (Nova 3 support removed)
  • Supports Nova 4 Light/Dark/System toggle
  • Supports Nova 4 brand colour for checkboxes
  • Replace third party Slug field with Nova's own Slug field!

I have followed the Nova upgrade guide and also take inspiration from other package upgrades. I am using my fork on a app with several uses of this field and it works great!

@dmason30 dmason30 marked this pull request as ready for review April 16, 2022 15:00
@dmason30
Copy link
Contributor Author

@pktharindu This is ready and I am using it in applications on production. I understand if you don't have a Nova 4 license you may not want to maintain this, let me know, and I will spin this off to a new package.

@pktharindu
Copy link
Owner

Looks great! Thank you! 👌🏻🚀

@pktharindu pktharindu merged commit ff250ad into pktharindu:master Apr 17, 2022
@dmason30 dmason30 deleted the nova-4 branch April 17, 2022 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants