Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more options for charge prices #851

Open
AusSandman opened this issue Jul 7, 2023 · 23 comments · Fixed by #945
Open

Add more options for charge prices #851

AusSandman opened this issue Jul 7, 2023 · 23 comments · Fixed by #945
Labels
backend Backend related enhancement New feature or request prio:high ui UI related

Comments

@AusSandman
Copy link

Allow time of use pricing in charge price by either integrating with TeslaMate Agile or allowing user to enter 4 timed Tarif rates with option to select days.

@pkuehnel
Copy link
Owner

pkuehnel commented Jul 7, 2023

Can you please explain this with an example?

@pkuehnel pkuehnel added the waiting for feedback Waiting for feedback of issue creator label Jul 7, 2023
@github-actions github-actions bot removed the waiting for feedback Waiting for feedback of issue creator label Jul 7, 2023
@pkuehnel pkuehnel added the waiting for feedback Waiting for feedback of issue creator label Jul 7, 2023
@AusSandman
Copy link
Author

Can you please explain this with an example?

When user does not have a fixed price per kWh of electricity, but price varies based on time of day. Ideally would like to prevent charging during Peak periods. But is useful to report charging costs when charging needs are not met by solar.

Example of pricing:
image

@github-actions github-actions bot removed the waiting for feedback Waiting for feedback of issue creator label Jul 8, 2023
@pkuehnel pkuehnel added enhancement New feature or request ui UI related backend Backend related prio:medium labels Jul 8, 2023
@pkuehnel
Copy link
Owner

pkuehnel commented Jul 8, 2023

either integrating with TeslaMate Agile

What do you mean with that?

@AusSandman
Copy link
Author

This add-on to TeslaMate https://github.com/MattJeanes/TeslaMateAgile allows time of use rates to feed into the TeslaMate to calculate charging costs. I am using this already with my TeslaMate. It doesn't however have the ability to set feed in rates.
This may be an easier way of getting the purchase price per kWh? Then just set a feed in rate in TeslaSolarCharger?
I would be nice to get accurate price of charging in TeslaSolarCharger.

@AusSandman
Copy link
Author

Would also be great to be able to set a "Do not Charge" period. This would be useful to prevent vehicle being charged during "Peak" power periods. This could just be a check box from the UI perhaps to not allow charging during "Peak? power.

@pkuehnel pkuehnel changed the title Time of use Tarif TeslaMateAgile integration Oct 12, 2023
@pkuehnel
Copy link
Owner

I will try to integrate the IPriceDataService from TeslaMateAgile

@pkuehnel
Copy link
Owner

pkuehnel commented Nov 1, 2023

@pkuehnel pkuehnel changed the title TeslaMateAgile integration Add more options for charge prices Nov 1, 2023
@pkuehnel pkuehnel linked a pull request Nov 1, 2023 that will close this issue
@pkuehnel
Copy link
Owner

pkuehnel commented Nov 6, 2023

@AusSandman Are you still interested in this feature? You can test it hopefully tomorrow.

@AusSandman
Copy link
Author

AusSandman commented Nov 6, 2023 via email

@pkuehnel
Copy link
Owner

pkuehnel commented Nov 7, 2023

Sorry did not have the time today. Will take a few more days.

@pkuehnel
Copy link
Owner

@AusSandman Can you give me your time based pricings and also your timezone? For now the backend is Ready but the UI is not, so I need to generate a JSON for you which you can send to TeslaSolarCharger so it calculates the correct prices for you and you can test already.

@AusSandman
Copy link
Author

  - FixedPrice__TimeZone=Australia/Perth
  - FixedPrice__Prices__0=00:00-06:00=0.1845
  - FixedPrice__Prices__1=06:00-09:00=0.2255
  - FixedPrice__Prices__2=09:00-15:00=0.082
  - FixedPrice__Prices__3=15:00-21:00=0.5125
  - FixedPrice__Prices__4=21:00-23:00=0.2255
  - FixedPrice__Prices__5=23:00-24:00=0.1845

@pkuehnel
Copy link
Owner

In the meantime UI got ready as well. Just change the Tag of TeslaSolarCharger in your docker-compose.yml from :latest to :edge and update everything with

docker compose pull && docker compose up -d

@pkuehnel
Copy link
Owner

Please provide me feedback if everything is working and calculated correctly. Note If you update a Charge Price with a valid since date in the past all prices get updated based on that date, in TSC and in TeslaMate as well.

@AusSandman
Copy link
Author

Having issues getting TSC to work at all since my car updated to 2023.38.6. So hard to tell at this point. Managed to get prcing data in but car seems to charge itself and TSC doesn't stop it anymore like it used to.

@pkuehnel
Copy link
Owner

But it should work. Did you update TeslaMate as well? You need the latest TeslaMate version. Can you take a screenshot of TSC when it should stop charging but does not?

@AusSandman
Copy link
Author

I already have updated teslamate. TSC (and teslmate) both show the car as not charging when it is. This is rectified if I wake the car up, but there is an issue I am guessing with the car software version?
I will try get a screenshot of this tomorrow.

@pkuehnel
Copy link
Owner

Hmm. This should be fixed with the latest version of TeslaMate (1.27.4 should be displayed at the bottom of TeslaMate --> Settings). I am also on 2023.38.6 with my car, and everything is still working.

@AusSandman
Copy link
Author

I am running TeslaMate 1.27.4. Might try a two button reset on the car tomorrow.

@pkuehnel
Copy link
Owner

And additionally a reboot of your Docker host.

@AusSandman
Copy link
Author

AusSandman commented Nov 16, 2023

So, good news is after rebooting my car TCS is working again. Costs appear to calculating correctly. I will try a few other times over the next week and see how it does.
image

@pkuehnel
Copy link
Owner

Charge Cost should display the complete cost of the charge, Price per kWh are the average cost per kWh based on used grid kWh (including when these kWh were used) and solar kWh. I think best would be if you could check when no solar power was used.

@AusSandman
Copy link
Author

I have checked charging at night, but as some battery power was used it has calculated that as solar (which is fine).
So calculations apear to be correct.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Backend related enhancement New feature or request prio:high ui UI related
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants