Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for @file:my.file in Command Line Parameters #65

Merged
merged 1 commit into from Feb 12, 2018

Conversation

tw-bert
Copy link
Contributor

@tw-bert tw-bert commented Feb 12, 2018

This patch adds support for @file:my.file in Command Line Parameters. The parameter is replaced by the file contents of the requested file.
By design: only supported in ARGV, not in KEYS. Can be repeated for multiple files, and combined with normal parameters.
Needed when passing binary data (like MSGPACK), or formatted human-readable JSON, to the Redis Lua debug session.

This patch adds support for @file:my.file in Command Line Parameters. The parameter is replaced by the file contents of the requested file.
By design: only supported in ARGV, not in KEYS. Can be repeated for multiple files, and combined with normal parameters.
Needed when passing binary data (like MSGPACK), or formatted human-readable JSON, to the Redis Lua debug session.
@pkulchenko
Copy link
Owner

@tw-bert, looks good, but why use @file: as the prefix instead of @? Is it because there may be values that start from @?

@tw-bert
Copy link
Contributor Author

tw-bert commented Feb 12, 2018

Yes, exactly. My guess is that @file: is strong enough to not cause conflicts in real world scenarios, although 100% certainty cannot be given.

@pkulchenko pkulchenko merged commit 884264e into pkulchenko:master Feb 12, 2018
pkulchenko added a commit that referenced this pull request Feb 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants