Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

any filter values should only get row with any values back #7

Closed
GlenDC opened this issue Apr 18, 2024 · 0 comments · Fixed by #9
Closed

any filter values should only get row with any values back #7

GlenDC opened this issue Apr 18, 2024 · 0 comments · Fixed by #9
Assignees
Labels
bug Something isn't working
Milestone

Comments

@GlenDC
Copy link
Member

GlenDC commented Apr 18, 2024

The behaviour where inserted rows with an any value for a focussed property that match for all given values of that property is correct. This is desired and what is wanted. It is the opposite direction however which is currently wrong and which will require another breaking change release.

When querying one can specify a value desired for a filter map property. This can also be an any value given it lives within the same type dimension as the property of that row to begin with. At first this was seen as a side effect and not desired. However this is actually meaningful and in that light it turns out that current behaviour is wrong. In v0.3 (and before) we ignore the query value in case it is an any value, which has the indirect effect that all rows will match regardless of the value. This also includes undefined ones. This is however incorrect for two reasons:

  • it does not transfer the right intent. An any value has a specific meaning, that it can be consumed as anything. This is very different from a row with a specific value. When a specific value is searched it is correct for a row with an any value for that property to be matched among the rows with the specific values. However it is not correct for rows with specific values to match when searching for rows with an any value. Querying for an instance is only the beginning. The reason why a row was desired to begin with changes the game entirely;
  • matching on rows with specific values, when searching for rows with any value, also rigs the odds on what value to eventually land. Any value is perfectly fair as it can equally match on any of the possible values within the type's dimension space. As soon as you add a specific value to that mix you however have a greater chance to land on that specific value over all the other possibilities. The greater the dimension space the more the game is rigged.

This has to be corrected, but does require a breaking change, as it is a change in behaviour correction.

@GlenDC GlenDC added the bug Something isn't working label Apr 18, 2024
@GlenDC GlenDC added this to the 0.4.0 milestone Apr 18, 2024
@GlenDC GlenDC self-assigned this Apr 18, 2024
@GlenDC GlenDC mentioned this issue Apr 18, 2024
GlenDC added a commit that referenced this issue Apr 18, 2024
@GlenDC GlenDC closed this as completed in #9 Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant