The Remaster PR #1315
Merged
The Remaster PR #1315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously this would've used CRLF on Windows and LF on Linux, now it's using CRLF on all platforms, as it's the current format
this is the version from Mapbox, just to see how well it performs. It definitely needs improvements as of now. I'm going to include the atlas.json, but it will be excluded once the pr is ready to be merged
Changed the codebase to https://github.com/Twista/python-polylabel/ and rounded results
to centroid vs pole of inaccessability
and tweaked the treshold a bit
ab-gh
approved these changes
May 13, 2022
This was referenced Mar 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussions are better to be done on #1314.
Closes #1314, extension of #1149.