Manwar prc pod document fix #25
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he distribution. It contains link to the repository hosted on GitHub.
…packages pod document: - Plack::Middleware::Session::Cookie - Plack::Session::Store::Cache
…eware::Session::Cookie.
the "AUTHOR" section of the pod document of the package Plack::Session::Store::DBI.
Yep, it's fixed with 06c9d18 |
| @@ -238,6 +238,10 @@ Tatsuhiko Miyagawa | |||
|
|
|||
| Stevan Little E<lt>stevan.little@iinteractive.comE<gt> | |||
|
|
|||
| =head1 REPOSITORY | |||
There was a problem hiding this comment.
repository info is already in META info and can be visible on search.cpan and metacpan, I'd avoid repeating that kind of info in multiple places.
|
I cherry picked 892ce9b but all other fixes are about metadata, which I don't think is a good idea to have scattered around. Thanks for your work, but I will keep this as is, and leave the canonical metadata in its dist meta files. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
As a part of Pull Request Challenge (initiated by Neil Bowers), I got the distribution plack-middleware-session. I have forked from the master and then created a branch "MANWAR-PRC-pod-document-fix". The branch contains mainly pod document related fixes. Changes are grouped in 4 individual commits:
commit b829c58
commit 9d776c7
commit 9359dc7
commit 892ce9b
One more thing I noticed is that all packages of Plack::Session::* has the $VERSION set to 0.23 except for one package Plack::Session::Store::DBI which is set as 0.10. Does this also need to be same as 0.23?
In my humble opinion, I reckon every package, which is part of "plack-middleware-session" distribution should have the same version i.e. 0.25. What do you think?
Last but not the least, thanks for the great work for the Perl Community.
Best Regards,
Mohammad S Anwar (MANWAR)