New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manwar prc pod document fix #25

Closed
wants to merge 4 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@manwar
Contributor

manwar commented Jan 4, 2015

Hi,

As a part of Pull Request Challenge (initiated by Neil Bowers), I got the distribution plack-middleware-session. I have forked from the master and then created a branch "MANWAR-PRC-pod-document-fix". The branch contains mainly pod document related fixes. Changes are grouped in 4 individual commits:

commit b829c58
commit 9d776c7
commit 9359dc7
commit 892ce9b

One more thing I noticed is that all packages of Plack::Session::* has the $VERSION set to 0.23 except for one package Plack::Session::Store::DBI which is set as 0.10. Does this also need to be same as 0.23?

In my humble opinion, I reckon every package, which is part of "plack-middleware-session" distribution should have the same version i.e. 0.25. What do you think?

Last but not the least, thanks for the great work for the Perl Community.

Best Regards,
Mohammad S Anwar (MANWAR)

manwar added some commits Jan 4, 2015

- Added section "REPOSITORY" to the pod document of all packages in t…
…he distribution. It contains

  link to the repository hosted on GitHub.
- Added the missing section "COPYRIGHT AND LICENSE" to the following …
…packages pod document:

  - Plack::Middleware::Session::Cookie
  - Plack::Session::Store::Cache
- Fixed the pod link to package Catalyst::Plugin::Session::Store::DBI in
  the "AUTHOR" section of the pod document of the package Plack::Session::Store::DBI.
@miyagawa

This comment has been minimized.

Show comment
Hide comment
@miyagawa

miyagawa Jan 4, 2015

Member

One more thing I noticed is that all packages of Plack::Session::* has the $VERSION set to 0.23 except for one package Plack::Session::Store::DBI which is set as 0.10. Does this also need to be same as 0.23?

Yep, it's fixed with 06c9d18

Member

miyagawa commented Jan 4, 2015

One more thing I noticed is that all packages of Plack::Session::* has the $VERSION set to 0.23 except for one package Plack::Session::Store::DBI which is set as 0.10. Does this also need to be same as 0.23?

Yep, it's fixed with 06c9d18

@@ -238,6 +238,10 @@ Tatsuhiko Miyagawa
Stevan Little E<lt>stevan.little@iinteractive.comE<gt>
=head1 REPOSITORY

This comment has been minimized.

@miyagawa

miyagawa Jan 4, 2015

Member

repository info is already in META info and can be visible on search.cpan and metacpan, I'd avoid repeating that kind of info in multiple places.

@miyagawa

miyagawa Jan 4, 2015

Member

repository info is already in META info and can be visible on search.cpan and metacpan, I'd avoid repeating that kind of info in multiple places.

@miyagawa

This comment has been minimized.

Show comment
Hide comment
@miyagawa

miyagawa Jan 4, 2015

Member

I cherry picked 892ce9b but all other fixes are about metadata, which I don't think is a good idea to have scattered around. Thanks for your work, but I will keep this as is, and leave the canonical metadata in its dist meta files.

Member

miyagawa commented Jan 4, 2015

I cherry picked 892ce9b but all other fixes are about metadata, which I don't think is a good idea to have scattered around. Thanks for your work, but I will keep this as is, and leave the canonical metadata in its dist meta files.

@miyagawa miyagawa closed this Jan 4, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment