Oops, weaken should happen outside the callback

plack · Jan 25, 2011 · fb48a98 · fb48a98
1 parent d2a04dc
commit fb48a98
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/lib/Plack/Middleware/SimpleLogger.pm b/lib/Plack/Middleware/SimpleLogger.pm
@@ -15,11 +15,12 @@ sub call {
     my $min = $level_numbers{ $self->level || "debug" };
 
     my $env_ref = $env;
+    Scalar::Util::weaken($env_ref);
+
     $env->{'psgix.logger'} = sub {
         my $args = shift;
 
         if ($level_numbers{$args->{level}} >= $min) {
-            Scalar::Util::weaken($env_ref);
             $env_ref->{'psgi.errors'}->print($self->format_message($args->{level}, $args->{message}));
         }
     };