Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

app reload with plackup -r #234

Closed
knutov opened this issue Jul 19, 2011 · 1 comment
Closed

app reload with plackup -r #234

knutov opened this issue Jul 19, 2011 · 1 comment

Comments

@knutov
Copy link

knutov commented Jul 19, 2011

It looks like there is a bug in two latest Plack releases -

when I use Plack-0.9979
and do
plackup -E development -p 3000 -r -R /path1,/path2,/path3 -a ./bin/
app.pl
application reloads when I'm changing some modules in /path2 for
example (I do 'use' them in app.pl) .

With Plack-0.9980 and Plack-0.9981 it does not work after ~3-4
reloads.

./bin/app.pl is a Dancer app if it is important.

ps: perl v5.10.1, ubuntu 11.04

'does not work' means:

-- /home/[...]/lib/Routes/Domains.pm updated.
Killing the existing server (pid:21769)

first time (but I do not see killing in log in terminal, I do not see string
[21769] core @0.004555> loading handler 'Dancer::Handler::PSGI' in /usr/local/share/perl/5.10.1/Dancer.pm l. 352
HTTP::Server::PSGI: Accepting connections at http://0:3000/
after this killing

and no reaction at all on next files changes after this first strange killing.
@miyagawa
Copy link
Member

See #223 - this is a duplication. I just merged the commit, so please test if the git master works for you.

miyagawa added a commit that referenced this issue Jul 19, 2011
@miyagawa
Checking in changes prior to tagging of version 0.9982.
cdcdfc6 
Changelog diff is:

diff --git a/Changes b/Changes
index f57496c..36891b7 100644
--- a/Changes
+++ b/Changes
@@ -2,6 +2,12 @@ Revision history for Perl extension Plack

 Take a look at http://github.com/miyagawa/Plack/issues for the planned changes before 1.0 release.

+0.9982  Tue Jul 19 13:07:35 PDT 2011
+    [BUG FIXES]
+        - Fixed the bug in restarter introduced in 0.9980 (nihen) #223 #234
+        - Removed a debug statement left over in Plack::Util
+        - Fixed warnings in Lint
+
 0.9981  Mon Jul 18 17:24:11 PDT 2011
     [BUG FIXES]
         - Plack::Request: Added a sanity check to remove newlines from headers to follow
miyagawa added a commit that referenced this issue Sep 27, 2011
@miyagawa
Checking in changes prior to tagging of version 0.9983.
8242f88 
Changelog diff is:

diff --git a/Changes b/Changes
index 36891b7..e66c482 100644
--- a/Changes
+++ b/Changes
@@ -2,6 +2,23 @@ Revision history for Perl extension Plack

 Take a look at http://github.com/miyagawa/Plack/issues for the planned changes before 1.0 release.

+0.9983  Tue Sep 27 09:55:48 PDT 2011
+    [BUG FIXES]
+        - Fixed a typo in nginx FastCGI configuration
+        - Clone HTTP headers in Response->finalize #237 (chip)
+        - Fixed Directory app not displaying the right path in its title
+        - Changed IPv6 default listen address to wildcard (ollyg)
+        - Fixed the FastCGI handler with web-server mode on Win32
+
+    [NEW FEATURES]
+        - Added psgix.harakiri for Apache handlers
+
+    [IMPROVEMENTS]
+        - Prefer Corona when Coro is detected #236 (chip)
+        - Increased Pod::Usage dependency
+        - Improved Plack::Test documentation (chromatic)
+        - Lint now checks if SCRIPT_NAME eq '/' which is forbidden in the spec (chromatic)
+
 0.9982  Tue Jul 19 13:07:35 PDT 2011
     [BUG FIXES]
         - Fixed the bug in restarter introduced in 0.9980 (nihen) #223 #234
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@miyagawa @knutov