Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement harakiri #329

Closed
wants to merge 2 commits into from
Closed

implement harakiri #329

wants to merge 2 commits into from

Conversation

damil
Copy link

@damil damil commented Sep 19, 2012

Hi folks,

Implemented harakiri in Server::PSGI, following Miyagawa's suggestion.

-------- Message original --------
Sujet: Re: harakiri
Date : Tue, 18 Sep 2012 12:12:35 +0900
De : Tatsuhiko Miyagawa miyagawa@cookpad.com
Pour : laurent dami laurent.dami@free.fr

On Sep 18, 2012, at 12:11 PM, laurent dami wrote:

Le 18.09.2012 04:38, Tatsuhiko Miyagawa a écrit :

re https://metacpan.org/module/DAMI/HTTP-Server-PSGI-Mortal-0.01/lib/HTTP/Server/PSGI/Mortal.pm
have you seen psgix.harakiri extension?
http://search.cpan.org/~miyagawa/PSGI-1.101/PSGI/Extensions.pod
Guess that can be easily implemented in HTTP::Server::PSGI as well.

Tatsuhiko Miyagawa

Hi,

I didn't know about this harakiri extension.

Indeed if you implement that extension in HTTP::Server::PSGI, then I can remove my ::Mortal subclass which will become useless.
You can implement that and send a pull request on github too :)

@miyagawa
Copy link
Member

I will take care of the fix.

@miyagawa miyagawa closed this Sep 19, 2012
miyagawa added a commit that referenced this pull request Sep 19, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants